Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement file restore on top of FUSE instead of vhdimount #6409

Merged
merged 17 commits into from
Sep 20, 2022

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Sep 6, 2022

please, review by commit

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@fbeauchamp fbeauchamp changed the title feat(xo-web): reactivate file restore for s3 feat(xo-web): Implement file restore for s3/encrypted backups Sep 7, 2022
@fbeauchamp fbeauchamp force-pushed the feat_file_level_restore branch 2 times, most recently from 2bbd245 to 82f93c7 Compare September 12, 2022 13:15
@fbeauchamp
Copy link
Collaborator Author

@julien-f how should we update the installation/ Xoa scripts since vhdimount is not needed anymore

@vates/fuse-vhd/index.js Outdated Show resolved Hide resolved
@vates/fuse-vhd/index.js Outdated Show resolved Hide resolved
@fbeauchamp fbeauchamp force-pushed the feat_file_level_restore branch 2 times, most recently from e00bc2f to c3283dc Compare September 15, 2022 15:19
@vates/fuse-vhd/index.js Outdated Show resolved Hide resolved
@vates/fuse-vhd/index.js Outdated Show resolved Hide resolved
@vates/fuse-vhd/index.js Outdated Show resolved Hide resolved
fbeauchamp and others added 2 commits September 20, 2022 09:39
Co-authored-by: Julien Fontanet <julien.fontanet@isonoe.net>
Co-authored-by: Julien Fontanet <julien.fontanet@isonoe.net>
@julien-f julien-f changed the title feat(xo-web): Implement file restore for s3/encrypted backups feat: implement file restore on top of FUSE instead of vhdimount Sep 20, 2022
@julien-f julien-f merged commit 46fe3be into master Sep 20, 2022
@julien-f julien-f deleted the feat_file_level_restore branch September 20, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants