Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-vmdk-to-vhd): overprovision vmdk size to generate ova in one pass #6487

Merged
merged 4 commits into from
Nov 23, 2022

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Oct 26, 2022

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@fbeauchamp fbeauchamp marked this pull request as ready for review October 28, 2022 08:04
@fbeauchamp fbeauchamp force-pushed the feat_speedup_ova branch 2 times, most recently from e278503 to ddd8652 Compare November 3, 2022 10:22
packages/xo-vmdk-to-vhd/src/vmdk-generate.js Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-vmdk-to-vhd/src/index.js Outdated Show resolved Hide resolved
@fbeauchamp fbeauchamp force-pushed the feat_speedup_ova branch 2 times, most recently from 313f3b5 to e30bfc8 Compare November 14, 2022 14:49
@julien-f julien-f merged commit 96b5cb2 into master Nov 23, 2022
@julien-f julien-f deleted the feat_speedup_ova branch November 23, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants