Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-server): import multiple from ESXi #6708

Merged
merged 9 commits into from
Mar 28, 2023
Merged

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Mar 8, 2023

Parameter

  concurrency: number of VM import in parallel (during each import, the disks are imported in parallel) 
  host:  esxi host address
  network: XCP network uuid used for the imported VM
  password: esxi host password
  sr: storage uuid used to write the disks
  sslVerify: make esxi certificiate verification, default true, optionnal
  stopSource: stop the source before importing last delta, default false
  stopOnError: stop on the first error , default true . Warning, change the response format
  thin: import thinned disk
  user: esxi host user name
  vms: vm to be imported , json:[2,9,18]

Response :

On success
[esxiVmId]:vmUuuid , for example :

{
  '2': '663d3f9a-5e58-b35b-f720-c1d0922ba6f8',
  '9': 'df9216c2-1b2b-aba6-df76-fdaa80df8c93'
}

On Error: throw an error. If stopOnError is false, continue when an error occurs, throws an error at the end with a succeeded property listing the VM properly imported

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@fbeauchamp fbeauchamp changed the title Feat(xo-server): import import multiple from esxi Feat(xo-server): import multiple from esxi Mar 8, 2023
@fbeauchamp fbeauchamp marked this pull request as ready for review March 9, 2023 13:37
@fbeauchamp fbeauchamp requested a review from julien-f March 9, 2023 13:40
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move params description in the JSON schema directly.

Documentation should go:

  • in code: when it explains the code
  • in commit: when it explains the change
  • in PR: when it explains PR specific things and how it should be reviewed.

Obviously it's not always obvious but it's the goal.

I'll add any PR doc you don't move to the code directly in the merged commit message

@fbeauchamp
Copy link
Collaborator Author

Move params description in the JSON schema directly.

Documentation should go:

* in code: when it explains the code

* in commit: when it explains the change

* in PR: when it explains PR specific things and how it should be reviewed.

Obviously it's not always obvious but it's the goal.

I'll add any PR doc you don't move to the code directly in the merged commit message

the comment in the PR is to ease @Rajaa-BARHTAOUI work, since she'll implement the front , especially the new options that are not present in single import ( stopOnError, concurrency ) . It can also facilitate the tests.

I think that the comment in the commit won't be as visible

@fbeauchamp fbeauchamp force-pushed the feat_import_multiple_esxi branch 3 times, most recently from 76ec35d to 5379cee Compare March 13, 2023 15:28
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-server/src/api/vm.mjs Outdated Show resolved Hide resolved
@julien-f julien-f removed their request for review March 28, 2023 07:48
@julien-f julien-f changed the title Feat(xo-server): import multiple from esxi feat(xo-server): import multiple from ESXi Mar 28, 2023
@julien-f julien-f merged commit 53e0f17 into master Mar 28, 2023
@julien-f julien-f deleted the feat_import_multiple_esxi branch March 28, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants