-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(xo-server): import multiple from ESXi #6708
Conversation
9f5eb89
to
0dc368b
Compare
0dc368b
to
54980df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move params description in the JSON schema directly.
Documentation should go:
- in code: when it explains the code
- in commit: when it explains the change
- in PR: when it explains PR specific things and how it should be reviewed.
Obviously it's not always obvious but it's the goal.
I'll add any PR doc you don't move to the code directly in the merged commit message
the comment in the PR is to ease @Rajaa-BARHTAOUI work, since she'll implement the front , especially the new options that are not present in single import ( stopOnError, concurrency ) . It can also facilitate the tests. I think that the comment in the commit won't be as visible |
0c59894
to
b380793
Compare
76ec35d
to
5379cee
Compare
3c9e9bc
to
2dbac7c
Compare
Parameter
Response :
On success
[esxiVmId]:vmUuuid
, for example :On Error: throw an error. If
stopOnError
is false, continue when an error occurs, throws an error at the end with asucceeded
property listing the VM properly importedCheck list
Fixes #007
orSee xoa-support#42
)CHANGELOG.unreleased.md
:${name} v${new version}
)cron/parse.spec.js
)xo-server
API changes, the corresponding test has been added to/updated onxo-server-test
Process
WiP:
(Work in Progress) if not ready to be mergedFrom the Four Agreements: