Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-web/import): ability to import multiple VMs from VMware #6718

Merged
merged 7 commits into from
Mar 29, 2023

Conversation

Rajaa-BARHTAOUI
Copy link
Contributor

@Rajaa-BARHTAOUI Rajaa-BARHTAOUI commented Mar 9, 2023

Screenshots

Screenshot from 2023-03-09 16-38-47

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@Rajaa-BARHTAOUI Rajaa-BARHTAOUI force-pushed the esxi-multiple-import branch 2 times, most recently from d8c4d84 to 6359b5b Compare March 10, 2023 15:19
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm-import/utils.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm-import/utils.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm-import/utils.js Show resolved Hide resolved
packages/xo-web/src/xo-app/vm-import/esxi/vm-data.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA requested a review from pdonias March 14, 2023 15:04
@MathieuRA MathieuRA requested a review from pdonias March 17, 2023 08:37
@pdonias
Copy link
Member

pdonias commented Mar 17, 2023

Ready to merge after #6708 and after removing the stub xo-server part.

@pdonias
Copy link
Member

pdonias commented Mar 29, 2023

@Rajaa-BARHTAOUI Could you rebase and remove what needs to be removed so we can merge?

@Rajaa-BARHTAOUI
Copy link
Contributor Author

@Rajaa-BARHTAOUI Could you rebase and remove what needs to be removed so we can merge?

Done

@pdonias pdonias merged commit f237101 into master Mar 29, 2023
@pdonias pdonias deleted the esxi-multiple-import branch March 29, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants