feat(xo-web/kubernetes): add number of cp choice #6809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathieuRA
reviewed
May 4, 2023
pdonias
requested changes
May 22, 2023
pdonias
approved these changes
May 25, 2023
MathieuRA
approved these changes
May 26, 2023
|
@pdonias Can you merge? |
|
Has it been tested end to end after the last changes? |
I have just finished a last end to end test to be sure. It's all good! |
pdonias
approved these changes
May 26, 2023
ggunullu
added a commit
that referenced
this pull request
Jun 6, 2023
ggunullu
added a commit
that referenced
this pull request
Jun 6, 2023
ggunullu
added a commit
that referenced
this pull request
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To merge along side with xoa#120
Description
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.md