fix(xo-web/new/network): correct type for vlan #6829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdonias
requested changes
May 12, 2023
julien-f
force-pushed
the
fix-createNetwork-vlan
branch
from
b3e40bf
to
939dc4e
Compare
BREAKING CHANGE: API method `network.create` no longer accepts a `string` for `vlan` param. Fixes https://xcp-ng.org/forum/post/62090 Either `number` or `undefined`, not an empty string.
julien-f
force-pushed
the
fix-createNetwork-vlan
branch
from
939dc4e
to
53461b8
Compare
pdonias
approved these changes
May 12, 2023
MathieuRA
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BREAKING CHANGE: API method
network.createno longer accepts astringforvlanparam.Fixes https://xcp-ng.org/forum/post/62090
Either
numberorundefined, not an empty string.Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.md