Skip to content

Commit

Permalink
fix(xo-web/new/network): correct type for vlan
Browse files Browse the repository at this point in the history
Fixes https://xcp-ng.org/forum/post/62090

Either `number` or `undefined`, not an empty string.
  • Loading branch information
julien-f committed May 12, 2023
1 parent 73d88cc commit b3e40bf
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
> Users must be able to say: “I had this issue, happy to know it's fixed”
- [VM] Fix `VBD_IS_EMPTY` error when converting to template [Forum#61653](https://xcp-ng.org/forum/post/61653) (PR [#6808](https://github.com/vatesfr/xen-orchestra/pull/6808))
- -[New/Network] Fix `invalid parameter error` when not providing a VLAN [Forum#62090](https://xcp-ng.org/forum/post/62090) (PR [#6829](https://github.com/vatesfr/xen-orchestra/pull/6829))

### Packages to release

Expand All @@ -30,5 +31,6 @@
<!--packages-start-->

- xo-server patch
- xo-web patch

<!--packages-end-->
2 changes: 1 addition & 1 deletion packages/xo-web/src/xo-app/new/network/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ const NewNetwork = decorate([
nbd,
pif: pif == null ? undefined : pif.id,
pool: pool.id,
vlan,
vlan: vlan.length !== 0 ? undefined : +vlan,
})
}

Expand Down

0 comments on commit b3e40bf

Please sign in to comment.