Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backups): use the right Sr for health check during replication #6902

Merged
merged 5 commits into from
Jun 22, 2023
Merged

feat(backups): use the right Sr for health check during replication #6902

merged 5 commits into from
Jun 22, 2023

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Jun 15, 2023 •
edited
Loading

Description

Health check during replication use the source health check instead of the configured Sr in the schedule

different SR (copy VM)
image

same SR (clone VM)
image

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@fbeauchamp fbeauchamp marked this pull request as ready for review June 15, 2023 16:01
@fbeauchamp fbeauchamp requested a review from ggunullu June 15, 2023 16:08
@fbeauchamp fbeauchamp requested a review from ggunullu June 19, 2023 13:09
@fbeauchamp fbeauchamp requested a review from julien-f June 19, 2023 13:30
@fbeauchamp fbeauchamp requested a review from julien-f June 22, 2023 09:07
@julien-f julien-f merged commit 311098a into master Jun 22, 2023
1 check passed
@julien-f julien-f deleted the feat_healtcheck_cr_sr branch June 22, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggunullu ggunullu ggunullu approved these changes

@julien-f julien-f Awaiting requested review from julien-f

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fbeauchamp @julien-f @ggunullu