fix(xo-server): add mbr for cloud-init only for windows VM #7050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbeauchamp
force-pushed
the
fix_cloudinit_mbr_non_windows
branch
from
eda315d
to
c3e5520
Compare
julien-f
reviewed
Sep 27, 2023
julien-f
changed the title
julien-f
requested changes
Sep 27, 2023
fbeauchamp
force-pushed
the
fix_cloudinit_mbr_non_windows
branch
from
5ae46c9
to
f2c26f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Kaleos use a minimal boot loader that don't like he MBR introduced by #6889
This PR try to add MBR only for windows template, by using the viridian flag in the platform property
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.md