Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(xo-server): add mbr for cloud-init only for windows VM #7050

Merged
merged 3 commits into from
Sep 28, 2023
Merged

fix(xo-server): add mbr for cloud-init only for windows VM #7050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9867e2
fix(xo-server): add mbr for cloud init only for windows VM
fbeauchamp Sep 21, 2023
f2c26f5
fixup! fix(xo-server): add mbr for cloud init only for windows VM
fbeauchamp Sep 27, 2023
0c09225
better changelog
julien-f Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.unreleased.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
> Users must be able to say: “I had this issue, happy to know it's fixed”

- [Backup/Mirror] Fix backup report not being sent (PR [#7049](https://github.com/vatesfr/xen-orchestra/pull/7049))
- [New VM] Only add MBR to cloud-init drive on Windows VMs to avoid booting issues (e.g. with Talos) (PR [#7050](https://github.com/vatesfr/xen-orchestra/pull/7050))

### Packages to release

Expand All @@ -30,5 +31,6 @@
<!--packages-start-->

- xo-server-backup-reports patch
- xo-server patch

<!--packages-end-->
5 changes: 4 additions & 1 deletion packages/xo-server/src/xapi/index.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1328,7 +1328,10 @@ export default class Xapi extends XapiBase {
)
),
])
buffer = addMbr(buffer)
// only add the MBR for windows VM
if (vm.platform.viridian === 'true') {
buffer = addMbr(buffer)
}
const vdi = await this._getOrWaitObject(
await this.VDI_create({
name_label: 'XO CloudConfigDrive',
Expand Down