Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(netbox): fix site property null/undefined cases #7145

Merged
merged 2 commits into from
Oct 31, 2023
Merged

fix(netbox): fix site property null/undefined cases #7145

merged 2 commits into from
Oct 31, 2023

Conversation

pdonias
Copy link
Member

@pdonias pdonias commented Oct 31, 2023

Introduced by 1d7559d

Description

When flattening a Netbox VM, the site property should be:

  • undefined if nbVm.site === undefined (site is not supported)
  • null if nbVm.site === null (site is supported and empty)
  • 'abc' if nbVm.site === 'abc' (site is supported and not empty)

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@pdonias pdonias requested a review from julien-f October 31, 2023 15:07
@julien-f julien-f merged commit a3ea70c into master Oct 31, 2023
1 check passed
@julien-f julien-f deleted the pierre-netbox-fix-site-value branch October 31, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-f julien-f Awaiting requested review from julien-f

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pdonias @julien-f