Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-web/xo-server/host/network): display and edit the IPv6 PIF field #7218

Merged
merged 3 commits into from
Dec 26, 2023
Merged

feat(xo-web/xo-server/host/network): display and edit the IPv6 PIF field #7218

merged 3 commits into from
Dec 26, 2023

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Dec 4, 2023 •
edited

Screenshots

Capture d’écran de 2023-12-20 15-00-14
Capture d’écran de 2023-12-20 15-00-21

Description

fixes #5400
can be tested on 172.16.210.83, host xcp-ng-3
Do not squash

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@MathieuRA MathieuRA changed the title feat(xo-web/host/PIF): display and edit PIF IPv6 feat(xo-web/xo-server/host/PIF): display and edit the PIF IPv6 field Dec 4, 2023
@MathieuRA MathieuRA changed the title feat(xo-web/xo-server/host/PIF): display and edit the PIF IPv6 field feat(xo-web/xo-server/host/network): display and edit the PIF IPv6 field Dec 4, 2023
@MathieuRA MathieuRA changed the title feat(xo-web/xo-server/host/network): display and edit the PIF IPv6 field feat(xo-web/xo-server/host/network): display and edit the IPv6 PIF field Dec 4, 2023
@MathieuRA MathieuRA self-assigned this Dec 4, 2023
@olivierlambert
Copy link
Member

Is it linked to an existing GH issue? If yes, we need to put it in the commit or PR so it will autoclose the original issue.

@MathieuRA MathieuRA marked this pull request as ready for review December 6, 2023 08:45
pdonias
pdonias requested changes Dec 13, 2023
View reviewed changes
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
pdonias
pdonias approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@pdonias pdonias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xo-web looks good. Needs to be tested after xo-server changes.

julien-f
julien-f reviewed Dec 21, 2023
View reviewed changes
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR could be split in multiple commits and not squashed:

  • IPv6 support in xo-server
  • IPv6 support in xo-web
  • tasks in xo-server

And please rebase on master.

@MathieuRA MathieuRA force-pushed the xo5/ipv6-pif branch 3 times, most recently from 980cf8e to eee5f6c Compare December 26, 2023 09:44
@julien-f julien-f merged commit ef4ecce into master Dec 26, 2023
1 check passed
@julien-f julien-f deleted the xo5/ipv6-pif branch December 26, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdonias pdonias pdonias approved these changes

@Pizzosaure Pizzosaure Pizzosaure approved these changes

@julien-f julien-f Awaiting requested review from julien-f

Assignees

@MathieuRA MathieuRA

Labels
Highlight
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some IPv6 related issues
5 participants
@MathieuRA @olivierlambert @julien-f @pdonias @Pizzosaure