Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some IPv6 related issues #5400

Closed
3 tasks
benjamreis opened this issue Nov 25, 2020 · 15 comments · Fixed by #7218
Closed
3 tasks

Some IPv6 related issues #5400

benjamreis opened this issue Nov 25, 2020 · 15 comments · Fixed by #7218

Comments

@benjamreis
Copy link
Contributor

  • When connecting a new host to XO, if the management interface is in IPv6, it is required to add extra [] arount the IPv6 address so that the HTTP(S) URL created from it is valid. I think from a user POV, the extra [] should be added by XO since a user doesn't know when the address is used to create a URL. Ideally, if a user add the [] XO should let as is, and add them if not.

  • The console address provided by the XAPI is wrong when the management interface is in IPv6, the [] around the IPv6 are missing. It will be fixed in XAPI but meanwhile XO should rework the URL to add them.

  • When displaying the addresses of an host in the network tab, only the host's PIFs' IPv4 are displayed. A pif can also have an IPv6 address in its IPv6 field, also when a PIF primary_address_type is IPv6 the IPv6 address should be displayed first.

@julien-f
Copy link
Member

  1. Not possible because a port can be specified by :<port>
  2. Do you have an example?
  3. ping @pdonias

@benjamreis
Copy link
Contributor Author

benjamreis commented Nov 25, 2020

Answer to point2:

# xe console-param-list uuid=b5182380-6605-2162-9688-db1f1bb60678 
uuid ( RO)             : b5182380-6605-2162-9688-db1f1bb60678
          vm-uuid ( RO): f45a6608-1ec2-4da7-808c-5104bac657cd
    vm-name-label ( RO): Control domain on host: localhost.localdomain
         protocol ( RO): RFB
         location ( RO): https://::1/console?ref=OpaqueRef:19f301f1-b4c8-42d4-b9f2-3a7dc3a20242
     other-config (MRW): 

The location field should be: https://[::1]/console?ref=OpaqueRef:19f301f1-b4c8-42d4-b9f2-3a7dc3a20242

This an issue in XAPI, but it can be worked around in XO, it means there's no console available for host in IPv6 only network.

@julien-f
Copy link
Member

  1. Curious to see a console address be localhost, XO would not be able to connect to it.
    Unless it becomes a real problem, I don't think we should take care of this for now, it appears difficult to get right.

@olivierlambert
Copy link
Member

For 1, maybe the UI can added them directly if there's no port specified. Is that doable?

@benjamreis
Copy link
Contributor Author

I edited the address, because my address is on public ipv6. :)

@julien-f
Copy link
Member

For 1, maybe the UI can added them directly if there's no port specified. Is that doable?

Nope because, AFAIK, there is no easy way to tell if there is a port or not.

@olivierlambert
Copy link
Member

In terms of UI, then I think we should then have a selector at some point, if we are "talking" in IPv4 or v6, so we can pre-position (or add) the brackets automatically, because it's not common at all for people not used to this.

I'll try to find how other software are dealing with this in terms of UI.

@pdonias
Copy link
Member

pdonias commented Nov 26, 2020

  1. Ok, we can change that. So the IP field of a PIF always contains an IPv4, right? And why is the IPv6 field a list of IPs? Can a PIF have more than one IPv6, somehow?

@benjamreis
Copy link
Contributor Author

benjamreis commented Nov 26, 2020

IPv6 field is always a list of IPv6 addresses (potentially empty).
primary_address_type is either equal to IPv4 or IPv6 to indicate which addresses are used by XAPI.

A PIF, and a VIF or even a physical interface can have mutlipe IPv4s and IPv6s at the same time, but it's VERY VERY RARE. Most of the time there's only one IP address by interface.
IMHO taking the first entry is enough.

@benjamreis
Copy link
Contributor Author

Quick update:
1 - impossible => perhaps a tips in UI or a clearer message error when attempting to use an IPv6 address withou []?
2 - The fix has been merged in XAPI, it'll be available in CH8.3 and XCP-ng8.3, we'll wait for the fix.

@olivierlambert
Copy link
Member

What's the status of this?

@pdonias
Copy link
Member

pdonias commented Sep 14, 2023

  1. I don't know if we want it for XO 5 but it should be trivial

@olivierlambert
Copy link
Member

Let's go with 3. first then :)

@olivierlambert olivierlambert added this to the Q4 2023 milestone Sep 14, 2023
@marcungeschikts
Copy link
Member

For now the wekan card is in Nice to have of XO6 swimlane in charteing board

@olivierlambert
Copy link
Member

Okay we probably want it for XO 5 and before the end of the year (since it's trivial and 8.3 will be here at the same time)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment