Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(xo-server/PIF): call PIF.forget to delete PIF #7221

Merged
merged 7 commits into from Dec 18, 2023
Merged

fix(xo-server/PIF): call PIF.forget to delete PIF #7221

merged 7 commits into from Dec 18, 2023

Conversation

Pizzosaure
Copy link
Contributor

Description

Fixes #7193
Calling pif.destroy generates PIF_IS_PHYSICAL error so we tried pif.forget instead

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@Pizzosaure Pizzosaure marked this pull request as ready for review December 6, 2023 12:31
@ajpri
Copy link

ajpri commented Dec 7, 2023

I decided to try switching to this branch. I was able to delete a PIF, solving my particular case.

pdonias
pdonias requested changes Dec 13, 2023
View reviewed changes
Copy link
Member

@pdonias pdonias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message: fix(xo-server/PIF): delete PIF with `PIF.forget` instead of `PIF.destroy`

CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@pdonias pdonias changed the title bugfix(xo-server/host/network): Can't remove PIF fix(xo-server/PIF): call PIF.forget to delete PIF Dec 18, 2023
@pdonias pdonias merged commit ceddddd into master Dec 18, 2023
1 check passed
@pdonias pdonias deleted the bugfixPIF branch December 18, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-f julien-f julien-f left review comments

@pdonias pdonias pdonias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't Remove PIF
4 participants
@Pizzosaure @ajpri @julien-f @pdonias