Can't Remove PIF

[ajpri]

Describe the bug
When trying to remove a PIF in Xen Orchestra CE 5fe53 of a removed physical adapter, an error message is received "PIF_IS_PHYSICAL()".

To Reproduce

1. Go to the Network tab of a host.
2. Click on the red trash can icon of a physical NIC that is no longer physically present.
3. See error

Expected behavior
For physical PIFs, pif-forget should be used on the backend to remove physical NICs.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please provide the following information):

• Node: 18.18.2
• hypervisor: XCP-ng 8.2, fully up to date

Additional context
Conversation at Forums and GitHub Docs Contribution

[olivierlambert]

Thanks a lot for the report 👍

[julien-f]

@olivierlambert So XO should automatically call PIF.forget when PIF.destroy throws PIF_IS_PHYSICAL?

[olivierlambert]

Ask @Fohdeesha for confirmation

[Fohdeesha]

I think this would be acceptable, yes. If not just calling PIF forget always instead of destroy. They both fully remove the PIF from XAPI as far as I know, Citrix's own documentation seems to call pif forget and not destroy when removing NICs: https://support.citrix.com/article/CTX127161/how-to-replace-a-network-interface-card-in-a-xenserver-host - however maybe we should ask @stormi for confirmation on the difference.

[stormi]

I have no idea but if needed we can ask someone in the XCP-ng Team to have a look at the code.

[olivierlambert]

I think that's the right approach. But yeah, let's do it in XO, and make some functional test on the XCP-ng team when the branch is ready to confirm it works as expected 👍

[olivierlambert]

@julien-f I let you assign the right XO dev on this