Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VDI_exportContent): create xapi task during NBD export for VHD #7228

Merged
merged 10 commits into from
Dec 19, 2023

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Dec 7, 2023

Screenshot

Capture d’écran de 2023-12-08 16-43-58

Description

See zammad#19003

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@MathieuRA MathieuRA self-assigned this Dec 7, 2023
@MathieuRA MathieuRA marked this pull request as ready for review December 8, 2023 09:44
packages/vhd-lib/createStreamNbd.js Outdated Show resolved Hide resolved
packages/vhd-lib/createStreamNbd.js Outdated Show resolved Hide resolved
@fbeauchamp
Copy link
Collaborator

since there is a new task visible in during the export, you can add a screenshot

packages/vhd-lib/createStreamNbd.js Outdated Show resolved Hide resolved
@julien-f julien-f self-requested a review December 13, 2023 10:24
@julien-f
Copy link
Member

  1. Is there a source for this PR?
  2. Why do we want to create a XAPI task instead of an XO task?

@olivierlambert
Copy link
Member

I can answer 2. I think: at least a XAPI task will be visible in XO Lite, so we can guess directly from the host there's something happening right now. It doesn't mean we can't do both (create the task on XAPI and build an XO task on top of it)

@fbeauchamp
Copy link
Collaborator

  1. I proposed this change, the source are multiple tickets of users asking why they don't have tasks, like the 19003.
  2. xo tasks are not ready to display any progress. xo task aren't easily available, for now, in this part of the code.

Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase.

@julien-f julien-f merged commit e66bcf2 into master Dec 19, 2023
1 check passed
@julien-f julien-f deleted the xo5/nbd-export-task branch December 19, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants