Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-web/pool/host): add warning if hosts don't have the same version #7280

Merged
merged 5 commits into from
Jan 18, 2024

Conversation

MathieuRA
Copy link
Member

Screenshots

Capture d’écran de 2024-01-04 16-49-52
Capture d’écran de 2024-01-04 16-58-48

Description

Fixes #7059
Tested only with hardcoded values

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@MathieuRA MathieuRA self-assigned this Jan 4, 2024
@MathieuRA MathieuRA requested review from Pizzosaure and OlivierFL and removed request for Pizzosaure January 4, 2024 16:04
@MathieuRA MathieuRA requested a review from pdonias January 8, 2024 14:19
packages/xo-web/src/xo-app/host/tab-general.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/index.js Outdated Show resolved Hide resolved
Copy link
Member

@pdonias pdonias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge after the small fix.

packages/xo-web/src/xo-app/home/host-item.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/home/pool-item.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA force-pushed the xo5/warningDifferentVersionWithinPool branch from cbd76d3 to 6845ca2 Compare January 17, 2024 15:08
@pdonias pdonias merged commit c1c122d into master Jan 18, 2024
1 check passed
@pdonias pdonias deleted the xo5/warningDifferentVersionWithinPool branch January 18, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display a warning when a pool is in upgrade state
3 participants