Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display a warning when a pool is in upgrade state #7059

Closed
olivierlambert opened this issue Sep 27, 2023 · 0 comments · Fixed by #7280 or #7293
Closed

Display a warning when a pool is in upgrade state #7059

olivierlambert opened this issue Sep 27, 2023 · 0 comments · Fixed by #7280 or #7293
Assignees
@MathieuRA
Labels
comp: GUI 🎨 difficulty 1: easy (hours) Helping support 🧑‍🚀 Highlight severity 1: low status::discussing 🗣️ status::in backlog ✅ type: enhancement ✨
Milestone
2024 - Q1

Comments

@olivierlambert
Copy link
Member

olivierlambert commented Sep 27, 2023 •
edited

We must be sure that one understands a "half upgraded" pool is dangerous and should be finished ASAP.

What to detect

If a master got a higher version than any slave in the pool, we should raise an alert in the UI

What to display

  1. Home/Pool view and Home/host view: using the current warning system
  2. Inside the pool view and the host view: probably on the bottom in the General tab

Extra note: works in an update process too. If the master was updated but NOT reboot, rebooting a slave should trigger a warming too.
@olivierlambert olivierlambert added this to the Q4 2023 milestone Sep 27, 2023
@olivierlambert olivierlambert modified the milestones: 2023 - Q4, 2024 - Q1 Dec 18, 2023
@MathieuRA MathieuRA self-assigned this Jan 3, 2024
This was referenced Jan 4, 2024
Merged
Merged
pdonias pushed a commit that referenced this issue Jan 18, 2024
@MathieuRA
feat(xo-web/pool/host): add warning if hosts don't have the same vers…
c1c122d 
…ion (#7280)

Fixes #7059
pdonias pushed a commit that referenced this issue Jan 19, 2024
@MathieuRA
feat(xo-web/host): ask for confirmation to reboot the updated slave h…
85ec261 
…ost if the master is not (#7293)

Fixes #7059

In case a slave host requires a reboot to apply updates and the master is using
the same version as the slave host, a confirmation modal is triggered.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MathieuRA MathieuRA

Labels
comp: GUI 🎨 difficulty 1: easy (hours) Helping support 🧑‍🚀 Highlight severity 1: low status::discussing 🗣️ status::in backlog ✅ type: enhancement ✨
Projects
None yet
Milestone
2024 - Q1
3 participants
@olivierlambert @MathieuRA @marcungeschikts