Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-web/host): ask for confirmation to reboot the updated slave host if the master is not #7293

Merged
merged 5 commits into from
Jan 19, 2024

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Jan 9, 2024

Screenshot

Capture d’écran de 2024-01-17 16-49-05

Description

⚠️ Only tested with hardcoded values ⚠️

Fixes #7059
In case a slave host requires a reboot to apply updates and the master is using the same version as the slave host, a confirmation modal is triggered.

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@MathieuRA MathieuRA self-assigned this Jan 9, 2024
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/common/xo/index.js Outdated Show resolved Hide resolved
@pdonias pdonias requested a review from julien-f January 16, 2024 09:24
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. restart (in modal title) vs reboot (in text and button)
  2. Shouldn't add a link to the pool master?

@pdonias pdonias requested a review from julien-f January 19, 2024 09:38
@julien-f julien-f self-requested a review January 19, 2024 10:00
@pdonias pdonias merged commit 85ec261 into master Jan 19, 2024
1 check passed
@pdonias pdonias deleted the xo5/warning-slave-reboot branch January 19, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display a warning when a pool is in upgrade state
4 participants