Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(xo-web/pool/advanced): show backup/migration network even when deleted #7303

Merged
merged 8 commits into from
Jan 30, 2024
Merged

fix(xo-web/pool/advanced): show backup/migration network even when deleted #7303

merged 8 commits into from
Jan 30, 2024

Conversation

Pizzosaure
Copy link
Contributor

Description

In pool advanced tab, show backup/migration network even if they no longer exist :
Screenshot from 2024-01-12 10-36-32

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@Pizzosaure Pizzosaure marked this pull request as ready for review January 12, 2024 10:04
MathieuRA
MathieuRA requested changes Jan 16, 2024
View reviewed changes
packages/xo-web/src/xo-app/pool/tab-advanced.js Outdated Show resolved Hide resolved
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
OlivierFL
OlivierFL reviewed Jan 19, 2024
View reviewed changes
Copy link
Contributor

@OlivierFL OlivierFL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add

MathieuRA
MathieuRA reviewed Jan 24, 2024
View reviewed changes
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/pool/tab-advanced.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/pool/tab-advanced.js Outdated Show resolved Hide resolved
MathieuRA
MathieuRA requested changes Jan 29, 2024
View reviewed changes
packages/xo-web/src/xo-app/pool/tab-advanced.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/pool/tab-advanced.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA merged commit 0f1f459 into master Jan 30, 2024
1 check passed
@MathieuRA MathieuRA deleted the bugfixDeletedNetwork branch January 30, 2024 10:28
@Pizzosaure Pizzosaure mentioned this pull request Jan 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdonias pdonias pdonias left review comments

@OlivierFL OlivierFL OlivierFL approved these changes

@MathieuRA MathieuRA MathieuRA approved these changes

Assignees

@Pizzosaure Pizzosaure

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Pizzosaure @pdonias @OlivierFL @MathieuRA