Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(xo-web/pool/advanced): added delete button in backup/migration network #7349

Merged
merged 5 commits into from
Jan 31, 2024
Merged

fix(xo-web/pool/advanced): added delete button in backup/migration network #7349

merged 5 commits into from
Jan 31, 2024

Conversation

MelissaFrncJrg
Copy link
Contributor

@MelissaFrncJrg MelissaFrncJrg commented Jan 31, 2024 •
edited by MathieuRA
Loading

Description

Introduced by 0f1f459

Fix for #7303
Added delete button

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

MathieuRA
MathieuRA requested changes Jan 31, 2024
View reviewed changes
packages/xo-web/src/xo-app/pool/tab-advanced.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/pool/tab-advanced.js Outdated Show resolved Hide resolved
@MelissaFrncJrg MelissaFrncJrg changed the title fix(xo-web/pool/advanced): show backup/migration network even when deleted fix(xo-web/pool/advanced): added delete button in backup/migration Network Jan 31, 2024
@MathieuRA MathieuRA changed the title fix(xo-web/pool/advanced): added delete button in backup/migration Network fix(xo-web/pool/advanced): added delete button in backup/migration network Jan 31, 2024
MathieuRA
MathieuRA requested changes Jan 31, 2024
View reviewed changes
packages/xo-web/src/xo-app/pool/tab-advanced.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/pool/tab-advanced.js Outdated Show resolved Hide resolved
@julien-f julien-f removed their request for review January 31, 2024 15:52
@MathieuRA MathieuRA merged commit fc2ca1f into master Jan 31, 2024
1 check failed
@MathieuRA MathieuRA deleted the fixDeleteNetwork branch January 31, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathieuRA MathieuRA MathieuRA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MelissaFrncJrg @MathieuRA