fix(xo-web/import/disk): can't change file name when importing from URL #7332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tested , it works well |
OlivierFL
approved these changes
Jan 26, 2024
MathieuRA
reviewed
Jan 26, 2024
Co-authored-by: Mathieu <70369997+MathieuRA@users.noreply.github.com>
MathieuRA
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes [#7326]
We used to try to update the state directly by modifying the reference of the 'mapNames' object, so I tried creating a new copy with ' ... ' operator instead.
Checklist
Commit
Fixes #007,See xoa-support#42,See https://...)Introduced byChangelog
CHANGELOG.unreleased.mdPR