Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(xo-web/import/disk): can't change file name when importing from URL #7332

Merged
merged 5 commits into from
Jan 30, 2024
Merged

fix(xo-web/import/disk): can't change file name when importing from URL #7332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6e1262f
fix(xo-web/import/disk): can't change file name when importing from URL
Pizzosaure Jan 23, 2024
296ef54
Changelog entry
Pizzosaure Jan 23, 2024
93d6d49
Update CHANGELOG.unreleased.md
Pizzosaure Jan 29, 2024
9a354ad
Merge branch 'master' into fixImportFromUrl
Pizzosaure Jan 30, 2024
231cc78
Merge branch 'master' into fixImportFromUrl
MathieuRA Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.unreleased.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
> Users must be able to say: “I had this issue, happy to know it's fixed”

- [Pool/Advanced] Show pool backup/migration network even if they no longer exist (PR [#7303](https://github.com/vatesfr/xen-orchestra/pull/7303))
- [Import/disk] Couldn't update 'name' field when importing from a URL [#7326](https://github.com/vatesfr/xen-orchestra/issues/7326) (PR [#7332](https://github.com/vatesfr/xen-orchestra/pull/7332))

### Packages to release

Expand Down
7 changes: 3 additions & 4 deletions packages/xo-web/src/xo-app/disk-import/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,10 +129,9 @@ const DiskImport = decorate([
onChangeFileType: (_, fileType) => ({ fileType }),
onChangeName:
(_, { target: { name, value } }) =>
({ mapNames }) => {
mapNames[name] = value
return { mapNames }
},
({ mapNames }) => ({
mapNames: { ...mapNames, [name]: value },
}),
onChangeSr: (_, sr) => ({ sr }),
onChangeUrl:
(_, { target: { value } }) =>
Expand Down
Loading