Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-web/Text): replace spaces with nbsp so that the text is always clickable #7411

Merged
merged 4 commits into from Feb 28, 2024

Conversation

pdonias
Copy link
Member

@pdonias pdonias commented Feb 27, 2024

See https://xcp-ng.org/forum/topic/8466

Description

On a Text field, if the user deletes the content, we show a placeholder so that the user can still see it and click it. But when the user enters white spaces, they get collapsed by the HTML rendering and the field becomes impossible to edit. This PR changes Text so that it displays non-breaking spaces instead of white spaces so the field remains visible and clickable.

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
pdonias and others added 2 commits February 27, 2024 14:03
Co-authored-by: Mathieu <70369997+MathieuRA@users.noreply.github.com>
@MathieuRA MathieuRA merged commit 561e94f into master Feb 28, 2024
1 check passed
@MathieuRA MathieuRA deleted the pierre-fix-editable-text-whitespace branch February 28, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants