Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent behavior of R_library() between released version 0.22.7 and current github 0.22.8 #1492

Closed
gaow opened this issue May 2, 2022 · 2 comments

Comments

@gaow
Copy link
Member

gaow commented May 2, 2022

I had an issue with R_library() which I pinpoint to this behavior:

Expected, in released version of SoS

>>> from sos.pattern import glob_wildcards
>>> glob_wildcards('{repo}@{pkg}', ['dscrutils@stephenslab/dsc/dscrutils'])
{'repo': ['dscrutils'], 'pkg': ['stephenslab/dsc/dscrutils']}
>>> from sos import __version__
>>> print(__version__)
0.22.7

Unexpected, in current github master branch

>>> from sos.pattern import glob_wildcards
>>> glob_wildcards('{repo}@{pkg}', ['dscrutils@stephenslab/dsc/dscrutils'])
{'repo': [], 'pkg': []}
>>> from sos import __version__
>>> print(__version__)
0.22.8
>>> 

From github blame records I dont think this change is intentional. So it should be a bug?

BoPeng added a commit that referenced this issue May 2, 2022
@BoPeng
Copy link
Contributor

BoPeng commented May 2, 2022

Sorry, I failed to identify a regression bug made by my programmer. It has been fixed.

@BoPeng BoPeng closed this as completed May 2, 2022
@BoPeng
Copy link
Contributor

BoPeng commented May 2, 2022

sos test suite is not working now due to #1371. The problem is that the "cleaner" tests uses execute_workflow function call instead of sos run command, so failed tests will fail to release file handlers etc, causing the next tests to fail. This is very tricky to fix and prevents me from detecting such problems.

Fixing the test suite should be a real priority now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants