-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Underscoreize query params #68
Conversation
@Reyvel This is great, would you be able to add some tests. |
sure, I'll look into it in the weekend |
Hi @Reyvel and @vbabiy, From my perspective this feature is required and it would be really great to have it inside your lib |
Hey guys, sorry for the absence, busy with my work and it doesn't use django unfortunately. Just checking this again rn. Here, I see the unittest doesn't use django testcase, so I am not sure how to implement my test. If someone can give me a direction that'll be superb anyway if some of you need this feature rn you can copy my code and use it as middleware. I have used it in my previous workplace. The middleware simply call underscoreize method. And the only downfall I know is it doesn't support expandable fields like used in Django Flex Fields. |
Is anybody working on this? I'd be happy to take this up and write the missing test cases! |
We're working on our implementation of filter, ordering and schema camelization/decamelization |
Could we add some tests and get this merged? As well as perhaps see if any outdated packages could be updated? @vbabiy |
@vbabiy i would also like to get this functionality in the project. |
Fixed in #123 |
query params isn't parsed to underscore, this means for filtering fields, user can't use camelCase. I add middleware to parse the request.GET, which will be turned into request.query_params by rest_framework.