Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: EditableCell about checked/unChecked Value, getDisable, rowKey m… #3418

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

xachary
Copy link

@xachary xachary commented Dec 14, 2023

…issing for updating

General

使用 EditableCell 遇到以下问题(场景):
1、当 editComponent 为 switch 的时候,设置 editComponentProps 的 checkedValue 和 unCheckedValue 无效。
2、假如存在多列均可以 edit,列A 受 列B 的值影响,列A 在 列B 为某个值的时候应该被禁用,此时 editDynamicDisabled 获得参数 record 中 列B 的值是旧值,没有变化,导致 列A 无法动态变成禁止 edit 状态。
3、禁用状的 EditableCell,”禁用“的表达应该提前,应该不允许点击切换至 editable 状态,无需用表单的禁用表达。
4、table 列设置里没有定义 id 列,在 beforeEditSubmit 返回到 record 中就不存在 id 属性,此时就缺失 id 用于提交表单了。此时可以根据 rowKey,补充至返回到 record 中。
5、使用 render 的时候,例如希望用彩色的 tag 显示记录的状态,此时出现类似上面”2“的情况,如果此记录经过 EditableCell 修改过,返回到 record 的是旧值,无法通过 render 显示最新的状态。

  • Pull request template structure not broken

Type

ℹ️ What types of changes does your code introduce?

👉 Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

👉 Put an x in the boxes that apply.

  • My code follows the style guidelines of this project
  • Is the code format correct
  • Is the git submission information standard?
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@wangjue666
Copy link
Collaborator

@xachary 新开个issue 贴个复现代码,我看下

@wangjue666 wangjue666 self-requested a review December 14, 2023 01:29
@xachary
Copy link
Author

xachary commented Dec 14, 2023

@xachary 新开个issue 贴个复现代码,我看下

已经发了issue,看看~

@wangjue666

@wangjue666
Copy link
Collaborator

@xachary ok 稍晚些时间我看看

@wangjue666 wangjue666 merged commit 404a472 into vbenjs:main Dec 15, 2023
2 checks passed
@xachary xachary deleted the fix-editable-cell branch December 15, 2023 09:47
WitMiao pushed a commit to WitMiao/vue-vben-admin that referenced this pull request Dec 17, 2023
chen178173956 pushed a commit to chen178173956/vue-vben-admin that referenced this pull request Dec 20, 2023
@vbenjs vbenjs locked and limited conversation to collaborators Aug 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants