Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ScreenShot #3826

Merged
merged 1 commit into from
May 10, 2024
Merged

Conversation

Torstentjh
Copy link

@doraemonxxx
Copy link

Hi there 🤗

Is a screenshot feature essential? Numerous tools are available for taking screenshots, including the default Windows OS screen capture function and Chrome extensions like Awesome Screenshot.

In some cases, if we want to export a chart, we could utilize the default export feature of ECharts. In my opinion, the feasibility of this feature is quite low, and not all users or developers would necessarily want or use it.

Thanks

@Torstentjh
Copy link
Author

hello 😄 @doraemonxxx
I think you are right, but this library also has many stars, which shows that it also has many usage scenarios. The main reason is that I saw this issue and communicated with the project members, so I made this function

@wangjue666 wangjue666 self-requested a review May 10, 2024 01:06
@wangjue666 wangjue666 merged commit 5a2d742 into vbenjs:main May 10, 2024
2 checks passed
@vbenjs vbenjs locked and limited conversation to collaborators Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants