Add builds for 4.13, 4.14 and 5.0 #7
Conversation
|
@vbmithr any chance of getting this merged. The fixes for OCaml 5 would be super useful. |
|
@tmcgilchrist if you are up for it maybe we could maintain a fork somewhere. @vbmithr alternatively would you consider transferring maintainership over to us? |
|
Happy to help co-maintain something, and contribute fixes and some better docs. |
|
FYI, @vbmithr has another OCaml library at least for the serialisation and deserialisation of Thrift. See: #4 (comment) Might make sense to progressively move towards that although admittedly the RPC side is missing afaict. |
|
@vthemelis that's cool, but as you said, it doesn't implement the RPC side of Thrift, and also it's using OCaml code as the 'source of truth', rather than the Thrift IDL file. The codegen is a pretty important aspect of Thrift, imho. @tmcgilchrist I think the ocaml-community GitHub org would be a nice place to host the fork. @c-cube can you advise us on setting up there? Or is there a good reason not to? Thx. |
|
@vbmithr is it possible to merge this? The build is green and it shouldn't need any extensive reviewing. |
No description provided.