Skip to content

Commit

Permalink
sagemathgh-36523: scipy: Fix build on macOS with Xcode CLT 15.0
Browse files Browse the repository at this point in the history
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->


<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
- Fixes sagemath#36342
- using the fix discussed at
mesonbuild/meson#12282
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36523
Reported by: Matthias Köppe
Reviewer(s): John H. Palmieri
  • Loading branch information
Release Manager committed Oct 29, 2023
2 parents 1b4847f + 489debe commit 5fdb3bc
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions build/pkgs/scipy/spkg-install.in
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
# https://github.com/scipy/scipy/issues/16536 - meson breaks when CXX="g++ -std=gnu++11"
export CXX=$(echo "$CXX" | sed 's/-std=[a-z0-9+]*//g')

# https://github.com/sagemath/sage/issues/36342
if [ "$UNAME" = "Darwin" ]; then
export LDFLAGS="$LDFLAGS -Wl,-ld_classic"
fi

cd src/

# mesonpy enforces the build-system requirements, including the strict version pins of numpy
Expand Down

0 comments on commit 5fdb3bc

Please sign in to comment.