sagemathgh-37403: Use "Issue #" for github issue links

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

As discussed in
sagemath#37390 (comment), we
change how Sphinx role ``:issue:`` is rendered. For example, short
```
By Issue sagemath#7797, there is a different implementation ...
```
instead of current
```
By github issue sagemath#7797, there is a different implementation ...
```
Arguments for the short form are

> Please don't do "Github issue". It is a lot of text with extremely
little extra value.

> In the trac era, it was "trac sagemath#7797".



<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#37403
Reported by: Kwankyu Lee
Reviewer(s): Travis Scrimshaw

build/pkgs/cylp/SPKG.rst

@@ -13,7 +13,7 @@ Eclipse Public License (EPL) version 2 (without a Secondary Licenses Notice).
 
 Note: This license is incompatible with the GPL according to
 https://www.gnu.org/licenses/license-list.html#EPL2;
-see also the discussion in :trac:`26511`.
+see also the discussion in :issue:`26511`.
 
 Upstream Contact
 ----------------

src/doc/en/developer/packaging.rst

@@ -240,7 +240,7 @@ before or after the package has been installed into
 ``$SAGE_LOCAL``. It is encouraged to put steps which modify already
 installed files in a separate ``spkg-postinst.in`` script template
 rather than combining them with ``spkg-install.in``.  This is because
-since :trac:`24106`, ``spkg-install`` does not necessarily install
+since :issue:`24106`, ``spkg-install`` does not necessarily install
 packages directly to ``$SAGE_LOCAL``.  However, by the time
 ``spkg-postinst`` is run, the installation to ``$SAGE_LOCAL`` is
 complete.
@@ -308,7 +308,7 @@ Likewise for :envvar:`CXXFLAGS`, :envvar:`FCFLAGS`, and :envvar:`F77FLAGS`.
 
     Prior to Sage 8.1 the shebang line was included, and the scripts were
     marked executable.  However, this is no longer the case as of
-    :trac:`23179`.  Now the scripts in the source tree are deliberately
+    :issue:`23179`.  Now the scripts in the source tree are deliberately
     written not to be directly executed, and are only made into executable
     scripts when they are copied to the package's build directory.
 
@@ -491,7 +491,7 @@ The following are also available, but rarely used.
   platforms.)  Check shared libraries loaded by ``EXECUTABLE`` (may be a
   program or another library) for a library starting with ``SONAME``, and
   if found appends ``SONAME`` to the ``LD_PRELOAD`` environment variable.
-  See :trac:`24885`.
+  See :issue:`24885`.
 
 
 .. _spkg-configure.m4:
@@ -660,7 +660,7 @@ constraints based on their experience and tests.  When a package
 update is made in order to pick up a critical bug fix from a newer
 version, then the lower bound should be adjusted.
 Setting upper bounds to guard against incompatible future changes is
-a complex topic; see :trac:`33520`.
+a complex topic; see :issue:`33520`.
 
 
 Concrete (pinned) requirements of ``normal``, ``wheel``, ``script`` packages: The ``package-version.txt`` file

src/doc/en/developer/packaging_sage_library.rst

@@ -265,7 +265,7 @@ that are imposed by the build-time dependencies.
 
 We can define some meaningful small distributions that just consist of
 a single or a few Cython modules. For example, **sagemath-tdlib**
-(:trac:`29864`) would just package the single
+(:issue:`29864`) would just package the single
 Cython module that must be linked with ``tdlib``,
 :mod:`sage.graphs.graph_decompositions.tdlib`. Starting with the Sage
 9.6 development cycle, as soon as namespace packages are activated, we
@@ -701,7 +701,7 @@ The whole ``.tox`` directory can be safely deleted at any time.
 
 We can do the same with other distributions, for example the large
 distribution **sagemath-standard-no-symbolics**
-(from :trac:`35095`), which is intended to provide
+(from :issue:`35095`), which is intended to provide
 everything that is currently in the standard Sage library, i.e.,
 without depending on optional packages, but without the packages
 :mod:`sage.symbolic`, :mod:`sage.calculus`, etc.
@@ -713,7 +713,7 @@ Again we can run the test with ``tox`` in a separate virtual environment::
 Some small distributions, for example the ones providing the two
 lowest levels, `sagemath-objects <https://pypi.org/project/sagemath-objects/>`_
 and `sagemath-categories <https://pypi.org/project/sagemath-categories/>`_
-(from :trac:`29865`), can be installed and tested
+(from :issue:`29865`), can be installed and tested
 without relying on the wheels from the Sage build::
 
   $ ./bootstrap && ./sage -sh -c '(cd pkgs/sagemath-objects && SAGE_NUM_THREADS=16 tox -v -v -v -e sagepython)'

src/doc/en/installation/source.rst

@@ -170,7 +170,7 @@ animations, Sage needs to use one of the packages :ref:`FFmpeg
    .. literalinclude:: void-recommended.txt
 
 In addition to these, if you don't want Sage to build optional packages that might
-be available from your OS, cf. the growing list of such packages on :trac:`27330`,
+be available from your OS, cf. the growing list of such packages on :issue:`27330`,
 install:
 
 .. tab:: Debian/Ubuntu
@@ -1050,7 +1050,7 @@ Environment variables dealing with specific Sage packages
 .. envvar:: OPENBLAS_CONFIGURE
 
   Adds additional configuration flags for
-  the OpenBLAS package that gets added to the ``make`` command. (see :trac:`23272`)
+  the OpenBLAS package that gets added to the ``make`` command. (see :issue:`23272`)
 
 .. envvar:: PARI_CONFIGURE
 

src/doc/en/prep/Quickstarts/Statistics-and-Distributions.rst

@@ -38,7 +38,7 @@ harmonic mean::
     2.5531914893617023
 
 We do not recommend to use Python's built in ``statistics`` module with Sage.
-It has a known incompatibility with number types defined in Sage, see :trac:`28234`.
+It has a known incompatibility with number types defined in Sage, see :issue:`28234`.
 
 
 Distributions

src/doc/en/reference/coercion/index.rst

@@ -271,7 +271,7 @@ discovered between steps 1 and 2 above.
     sage: f(3).parent()
     Rational Field
 
-Note that by :trac:`14711` Sage's coercion system uses maps with weak
+Note that by :issue:`14711` Sage's coercion system uses maps with weak
 references to the domain. Such maps should only be used internally, and so a
 copy should be used instead (unless one knows what one is doing)::
 

src/doc/en/reference/combinat/module_list.rst

@@ -10,7 +10,7 @@ Comprehensive Module List
 
     and copy pasting the result back there.
 
-.. TODO:: See :trac:`17421` for desirable improvements.
+.. TODO:: See :issue:`17421` for desirable improvements.
 
 .. toctree::
     :maxdepth: 1

src/doc/en/thematic_tutorials/coercion_and_categories.rst

@@ -723,7 +723,7 @@ A first note on performance
 ---------------------------
 
 The category framework is sometimes blamed for speed regressions, as in
-:trac:`9138` and :trac:`11900`. But if the category framework is *used
+:issue:`9138` and :issue:`11900`. But if the category framework is *used
 properly*, then it is fast. For illustration, we determine the time needed to
 access an attribute inherited from the element class. First, we consider an
 element that uses the class that we implemented above, but does not use the
@@ -1427,7 +1427,7 @@ Being able to do arithmetics involving elements of different parents, with the
 automatic creation of a pushout to contain the result, is certainly
 convenient\---but one should not rely on it, if speed matters. Simply the
 conversion of elements into different parents takes time. Moreover, by
-:trac:`14058`, the pushout may be subject to Python's cyclic garbage
+:issue:`14058`, the pushout may be subject to Python's cyclic garbage
 collection. Hence, if one does not keep a strong reference to it, the same
 parent may be created repeatedly, which is a waste of time. In the following
 example, we illustrate the slow\--down resulting from blindly relying on

src/doc/en/thematic_tutorials/explicit_methods_in_number_theory/nf_introduction.rst

@@ -310,7 +310,7 @@ root is :math:`x^6 + 10x^3 - 2x^2 + 25`.
 
 .. warning::
 
-   The following tests are currently broken until :trac:`5338` is
+   The following tests are currently broken until :issue:`5338` is
    fixed.
 
 .. skip

src/doc/en/thematic_tutorials/lie/weyl_groups.rst

@@ -122,7 +122,7 @@ and whose values are the roots, you may use the inverse family::
 
 .. NOTE::
 
-    The behaviour of this function was changed in :trac:`20027`.
+    The behaviour of this function was changed in :issue:`20027`.
 
 The Weyl group is implemented as a GAP matrix group. You therefore can
 display its character table as follows::

src/doc/en/thematic_tutorials/linear_programming.rst

@@ -455,7 +455,7 @@ following libraries are currently supported:
 * `CPLEX
   <https://www.ibm.com/products/ilog-cplex-optimization-studio/>`_:
   Proprietary, but available for free for researchers and students through
-  IBM's Academic Initiative.  Since :trac:`27790`, only versions 12.8 and
+  IBM's Academic Initiative.  Since :issue:`27790`, only versions 12.8 and
   above are supported.
 
   Install CPLEX according to the instructions on the

src/doc/en/thematic_tutorials/vector_calculus/vector_calc_advanced.rst

@@ -39,7 +39,7 @@ manifold endowed with a positive definite metric tensor::
     Riemannian metric g on the Euclidean space E^3
 
 Actually ``RR`` is used here as a proxy for the real field (this should be
-replaced in the future, see the discussion at :trac:`24456`) and the 53 bits of precision play
+replaced in the future, see the discussion at :issue:`24456`) and the 53 bits of precision play
 of course no role for the symbolic computations.
 
 Let us introduce spherical and cylindrical coordinates on

src/doc/en/thematic_tutorials/vector_calculus/vector_calc_plane.rst

@@ -500,7 +500,7 @@ manifold endowed with a positive definite metric tensor::
 
 Actually ``RR`` is used here as a proxy for the real field (this should
 be replaced in the future, see the discussion at
-:trac:`24456`) and the 53 bits of
+:issue:`24456`) and the 53 bits of
 precision play of course no role for the symbolic computations.
 
 The user atlas of `\mathbb{E}^2` has two charts::

src/sage/graphs/path_enumeration.pyx

@@ -1597,7 +1597,7 @@ def _all_paths_iterator(self, vertex, ending_vertices=None,
                 # the first vertex in the path). In this latter case we must
                 # not exit the new vertex again, so we do not consider it
                 # for further extension, but just yield it immediately. See
-                # trac #12385.
+                # Issue #12385.
                 frozen_path = frozenset(path)
                 for neighbor in neighbor_iterator(path[-1]):
                     if neighbor not in frozen_path:

src/sage/libs/giac/giac.pyx

@@ -2102,7 +2102,7 @@ class GiacInstance:
 
 libgiac=GiacInstance()
 
-# trac #23976 (bound threads with SAGE_NUM_THREADS)
+# Issue #23976 (bound threads with SAGE_NUM_THREADS)
 import os
 try:
     ncpus = int(os.environ['SAGE_NUM_THREADS'])

src/sage/libs/ntl/ntl_GF2EX.pyx

@@ -58,7 +58,7 @@ cdef class ntl_GF2EX():
         if modulus is None:
             raise ValueError("You must specify a modulus when creating a GF2E.")
 
-        str_x = str(x)  # can cause modulus to change  trac #25790
+        str_x = str(x)  # can cause modulus to change; Issue #25790
         self.c.restore_c()
         ccreadstr(self.x, str_x)
 

src/sage/libs/ntl/ntl_ZZ_p.pyx

@@ -127,7 +127,7 @@ cdef class ntl_ZZ_p():
                 mpz_to_ZZ(&den, (<Integer>v.denominator()).value)
                 ZZ_p_div(self.x, ZZ_to_ZZ_p(num), ZZ_to_ZZ_p(den))
             else:
-                str_v = str(v)  # can cause modulus to change  trac #25790
+                str_v = str(v)  # can cause modulus to change; Issue #25790
                 self.c.restore_c()
                 ccreadstr(self.x, str_v)
 

src/sage/libs/ntl/ntl_ZZ_pE.pyx

@@ -109,7 +109,7 @@ cdef class ntl_ZZ_pE():
                 self.x = ZZ_pX_to_ZZ_pE((<ntl_ZZ_pX>v).x)
             elif isinstance(v, (list, tuple)):
                 tmp_zzpx = <ntl_ZZ_pX>ntl_ZZ_pX(v, self.c.pc)
-                self.c.restore_c()   # allocating tmp_zzpx can change the current modulus trac #25790
+                self.c.restore_c()   # allocating tmp_zzpx can change the current modulus; Issue #25790
                 self.x = ZZ_pX_to_ZZ_pE(tmp_zzpx.x)
             elif isinstance(v, int):
                 PyLong_to_ZZ(&temp, v)
@@ -122,7 +122,7 @@ cdef class ntl_ZZ_pE():
                 mpz_to_ZZ(&temp, (<Integer>v).value)
                 self.x = ZZ_to_ZZ_pE(temp)
             else:
-                str_v = str(v)  # can cause modulus to change  trac #25790
+                str_v = str(v)  # can cause modulus to change; Issue #25790
                 self.c.restore_c()
                 ccreadstr(self.x, str_v)
 

src/sage/libs/ntl/ntl_ZZ_pX.pyx

@@ -111,7 +111,7 @@ cdef class ntl_ZZ_pX():
                     cc = x
                 ZZ_pX_SetCoeff(self.x, i, cc.x)
         elif v is not None:
-            s = str(v).replace(',', ' ').replace('L', '')  # can change the modulus trac #25790
+            s = str(v).replace(',', ' ').replace('L', '')  # can change the modulus; Issue #25790
             self.c.restore_c()
             ccreadstr(self.x, s)
 

src/sage/matrix/matrix0.pyx

@@ -5748,7 +5748,7 @@ cdef class Matrix(sage.structure.element.Matrix):
             # that it's 1.
             #
             # However, doing this naively causes trouble over inexact
-            # fields -- see trac #2256. The *right* thing to do would
+            # fields -- see Issue #2256. The *right* thing to do would
             # probably be to make sure that self.det() is nonzero. That
             # doesn't work here, because our det over an arbitrary field
             # just does expansion by minors and is unusable for even 10x10

src/sage/matrix/matrix2.pyx

@@ -7252,7 +7252,7 @@ cdef class Matrix(Matrix1):
             if e[1] and defect >= 0:
                 rows.extend(e[1] + [e[1][0].parent().zero_vector()] * defect)
             else:
-                # see trac #27842
+                # see Issue #27842
                 raise RuntimeError(
                         "failed to compute eigenvectors for eigenvalue %s, "
                         "check eigenvectors_left() for partial results" % e[0])

src/sage/misc/dev_tools.py

@@ -501,7 +501,7 @@ def import_statements(*objects, **kwds):
         sage: import_statements('deprecated_RR')
         Traceback (most recent call last):
         ...
-        LookupError: object named 'deprecated_RR' is deprecated (see github issue 17458)
+        LookupError: object named 'deprecated_RR' is deprecated (see Issue #17458)
         sage: lazy_import('sage.all', 'RR', namespace=sage.__dict__, deprecation=17458)
         sage: import_statements('RR')
         from sage.rings.real_mpfr import RR
@@ -612,7 +612,7 @@ def expand_comma_separated_names(obj):
             except IndexError:
                 if deprecation:
                     raise LookupError(
-                        "object named {!r} is deprecated (see github issue "
+                        "object named {!r} is deprecated (see Issue #"
                         "{})".format(name, deprecation))
                 else:
                     raise LookupError("no object named {!r}".format(name))

src/sage/misc/reset.pyx

@@ -7,7 +7,7 @@ import sys
 
 # Exclude these from the reset command.
 # DATA, base64 -- needed by the notebook
-# Add exit and quit to EXCLUDE to resolve trac #22529 and trac #16704
+# Add exit and quit to EXCLUDE to resolve Issue #22529 and Issue #16704
 EXCLUDE = set(['sage_mode', '__DIR__', 'DIR', 'DATA', 'base64', 'exit', 'quit'])
 
 

src/sage/misc/sagedoc.py

@@ -506,8 +506,7 @@ def process_dollars(s):
 pythonversion = sys.version.split(' ')[0]
 extlinks = {
     'python': (f'https://docs.python.org/release/{pythonversion}/%s', None),
-    'trac': ('https://github.com/sagemath/sage/issues/%s', 'github issue #%s'), # support :issue: for backward compatibility
-    'issue': ('https://github.com/sagemath/sage/issues/%s', 'github issue #%s'),
+    'issue': ('https://github.com/sagemath/sage/issues/%s', 'Issue #%s'),
     'wikipedia': ('https://en.wikipedia.org/wiki/%s', 'Wikipedia article %s'),
     'arxiv': ('https://arxiv.org/abs/%s', 'arXiv %s'),
     'oeis': ('https://oeis.org/%s', 'OEIS sequence %s'),

src/sage/modules/with_basis/indexed_element.pyx

@@ -1016,7 +1016,7 @@ def _unpickle_element(C, d):
     """
     return C._from_dict(d, coerce=False, remove_zeros=False)
 
-# Handle old CombinatorialFreeModuleElement pickles, see trac #22632
+# Handle old CombinatorialFreeModuleElement pickles, see Issue #22632
 from sage.misc.persist import register_unpickle_override
 register_unpickle_override("sage.combinat.free_module",
                            "CombinatorialFreeModuleElement",

src/sage/rings/finite_rings/finite_field_base.pyx

@@ -876,7 +876,7 @@ cdef class FiniteField(Field):
         return self.characteristic()**self.degree()
 
     # cached because constructing the Factorization is slow;
-    # see trac #11628.
+    # see Issue #11628.
     @cached_method
     def factored_order(self):
         """

src/sage/rings/polynomial/polynomial_real_mpfr_dense.pyx

@@ -705,7 +705,7 @@ cdef class PolynomialRealDense(Polynomial):
 
         TESTS::
 
-            sage: R.<x> = RR[]       # trac #17311
+            sage: R.<x> = RR[]  # Issue #17311
             sage: (x^2+1)(x=5)
             26.0000000000000
         """

src/sage/rings/rational.pyx

@@ -1640,7 +1640,7 @@ cdef class Rational(sage.structure.element.FieldElement):
 
         # We should be able to run the code in the sign == 1 case
         # below for both cases. However, we need to do extra work to
-        # avoid a bug in GMP's mpz_perfect_power_p; see trac #4612 for
+        # avoid a bug in GMP's mpz_perfect_power_p; see Issue #4612 for
         # more details.
         #
         # The code in the case of sign == -1 could definitely be

src/sage/sets/family.pyx

@@ -935,7 +935,7 @@ class FiniteFamilyWithHiddenKeys(FiniteFamily):
             hidden_function = unpickle_function(hidden_function)
         self.__init__(d['dictionary'], d['hidden_keys'], hidden_function)
         self.hidden_dictionary = d['hidden_dictionary']
-        # Old pickles from before trac #22955 may not have a 'keys'
+        # Old pickles from before Issue #22955 may not have a 'keys'
         if 'keys' in d:
             self._keys = d['keys']
         else:

src/sage/structure/factory.pyx

@@ -722,7 +722,7 @@ def generic_factory_unpickle(factory, *args):
             return F.get_object(*args)
         except TypeError:
             pass
-    # See trac #16349: When replacing a UniqueFactory by something else (e.g.,
+    # See Issue #16349: When replacing a UniqueFactory by something else (e.g.,
     # a UniqueRepresentation), then we get the object by calling.
     #
     # The first argument of a UniqueFactory pickle is a version number. We

src/sage/structure/parent.pyx

@@ -2503,7 +2503,7 @@ cdef class Parent(sage.structure.category_object.CategoryObject):
             return self._convert_from_hash.get(S)
         except KeyError:
             mor = self.discover_convert_map_from(S)
-            # Before trac #14711, the morphism has been
+            # Before Issue #14711, the morphism has been
             # put both into _convert_from_list and into
             # _convert_from_hash. But there is no reason
             # to have a double book-keeping, specifically

src/sage/symbolic/expression.pyx

@@ -7828,9 +7828,9 @@ cdef class Expression(Expression_abc):
             sage: gcd(I + I*x, x^2 - 1)
             x + 1
             sage: alg = SR(QQbar(sqrt(2) + I*sqrt(3)))
-            sage: gcd(alg + alg*x, x^2 - 1)  # known bug (trac #28489)
+            sage: gcd(alg + alg*x, x^2 - 1)  # known bug (Issue #28489)
             x + 1
-            sage: gcd(alg - alg*x, x^2 - 1)  # known bug (trac #28489)
+            sage: gcd(alg - alg*x, x^2 - 1)  # known bug (Issue #28489)
             x - 1
             sage: sqrt2 = SR(QQbar(sqrt(2)))
             sage: gcd(sqrt2 + x, x^2 - 2)    # known bug

src/sage/symbolic/function.pyx

@@ -1105,7 +1105,7 @@ cdef class BuiltinFunction(Function):
             sage: p3 = AFunction('p3', 3)
             sage: p3(x)                                                                 # needs sage.symbolic
             x^3
-            sage: loads(dumps(cot)) == cot    # trac #15138
+            sage: loads(dumps(cot)) == cot  # Issue #15138
             True
         """
         # check if already defined

src/sage_docbuild/builders.py

@@ -30,7 +30,7 @@
 build. Then new rst files are generated for new and updated modules. See
 :meth:`get_new_and_updated_modules()`.
 
-After :trac:`31948`, when Sage is built, :class:`ReferenceBuilder` is not used
+After :issue:`31948`, when Sage is built, :class:`ReferenceBuilder` is not used
 and its responsibility is now taken by the ``Makefile`` in ``$SAGE_ROOT/src/doc``.
 """
 
@@ -109,7 +109,7 @@ def builder_helper(type):
 
     TESTS:
 
-    Check that :trac:`25161` has been resolved::
+    Check that :issue:`25161` has been resolved::
 
         sage: from sage_docbuild.builders import DocBuilder
         sage: from sage_docbuild.__main__ import setup_parser