Skip to content

Commit

Permalink
sagemathgh-36910: System package quoting fixes
Browse files Browse the repository at this point in the history
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
The format of the `distros/*.txt` was underspecified. We now clarify
that there should be 1 package per line and no shell quoting.

We extend the system package scripts so that they apply shell quoting
when they print shell commands.
This fixes a failure seen in CI due to underquoting: https://github.com/
sagemath/sage/actions/runs/7202678226/job/19621287638#step:11:134

We also wrap the command lines that are displayed by `sage-spkg-info`
and formatted for the installation guide.
https://pianomister.github.io/diffsite/?url1=https%3A%2F%2Fdeploy-
preview-36910--sagemath-tobias.netlify.app%2Fhtml%2Fen%2Finstallation%2F
source&url2=https%3A%2F%2Fsagemath-
tobias.netlify.app%2Fhtml%2Fen%2Finstallation%2Fsource

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36910
Reported by: Matthias Köppe
Reviewer(s): Dima Pasechnik, Matthias Köppe
  • Loading branch information
Release Manager committed Dec 22, 2023
2 parents 612f59c + 7c0eb33 commit a1b5609
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit a1b5609

Please sign in to comment.