Skip to content

Commit

Permalink
sagemathgh-36467: Combine ci linter jobs
Browse files Browse the repository at this point in the history
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

to de-clutter the "checks" a bit.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36467
Reported by: Tobias Diez
Reviewer(s): Kwankyu Lee, Matthias Köppe
  • Loading branch information
Release Manager committed Oct 18, 2023
2 parents 433e825 + 5924072 commit eb03f27
Showing 1 changed file with 13 additions and 41 deletions.
54 changes: 13 additions & 41 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,60 +14,32 @@ concurrency:
cancel-in-progress: true

jobs:
lint-pycodestyle:
name: Code style check with pycodestyle
lint:
name: Lint
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Merge CI fixes from sagemath/sage
run: |
.ci/merge-fixes.sh
env:
GH_TOKEN: ${{ github.token }}

- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: 3.9
- name: Install pycodestyle
run: pip install tox pycodestyle
- name: Lint using pycodestyle

- name: Install dependencies
run: pip install tox pycodestyle relint

- name: Code style check with pycodestyle
run: tox -e pycodestyle-minimal
lint-relint:
name: Code style check with relint
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Merge CI fixes from sagemath/sage
run: |
.ci/merge-fixes.sh
env:
GH_TOKEN: ${{ github.token }}
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: 3.9
- name: Install relint
run: pip install tox relint
- name: Lint using relint

- name: Code style check with relint
run: tox -e relint -- src/sage/
lint-rst:
name: Validate docstring markup as RST
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Merge CI fixes from sagemath/sage
run: |
.ci/merge-fixes.sh
env:
GH_TOKEN: ${{ github.token }}
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: 3.9
- name: Install tox
run: pip install tox
- name: Lint using tox -e rst

- name: Validate docstring markup as RST
run: tox -e rst

0 comments on commit eb03f27

Please sign in to comment.