This repository has been archived by the owner on Dec 14, 2020. It is now read-only.
Fix receiver flow control #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Link should not send additional credits when there are queued transfers/messages waiting to be read via `Receiver.Receive`. Message decoding is moved into the `link.mux` goroutine so that the link can know how many messages are queued by checking the `link.messages` channel length. If the channel fills the link is effectively paused. The receiver can indicate it can process additional message and unblock the link my sending on `link.receiverReady`. When additional credits are issued, `link.linkCredit` must be updated before receiving any additional messages to ensure the sender and receiver stay in sync. Similarly, `link.deliveryCount` should not be arbitrarily changed based on a flow frame received from the sender.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link should not send additional credits when there are queued
transfers/messages waiting to be read via
Receiver.Receive. Messagedecoding is moved into the
link.muxgoroutine so that the link canknow how many messages are queued by checking the
link.messageschannel length. If the channel fills the link is effectively paused.
The receiver can indicate it can process additional message and unblock
the link my sending on
link.receiverReady.When additional credits are issued,
link.linkCreditmust be updatedbefore receiving any additional messages to ensure the sender and
receiver stay in sync.
Similarly,
link.deliveryCountshould not be arbitrarily changed basedon a flow frame received from the sender.