Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hide the existing stack trace of the original error message if exists. #18

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

mastrzyz
Copy link
Contributor

Currently we are creating a new Error to raise if we hit the max attempts.

This removes the original errors stack trace:

    Failed for 'test' for 2 times. Original Error: Failed for 'test' for 2 times. Original Error: error

      at APP.<anonymous> (node_modules/typescript-retry-decorator/src/retry.decorator.ts:44:15)
          at Generator.throw (<anonymous>)
      at rejected (node_modules/typescript-retry-decorator/dist/retry.decorator.js:6:65)

Instead, we should include the original stack trace if exists.

@mastrzyz
Copy link
Contributor Author

@vcfvct anything I missed here?

@vcfvct vcfvct merged commit bfc517b into vcfvct:master Aug 25, 2022
@vcfvct
Copy link
Owner

vcfvct commented Aug 25, 2022

looks great. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants