Made some parts of DeleteObjectPlugin public #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is okay, but before I merge I just wanted to ask - what properties on the combo box do you need access to? Does it make sense to simply expose the properties off of the combo box that are needed rather than the entire combo box? If a lot of the properties are needed, or if you envision other plugins needing access to the entire combo box let me know and I'll merge. |
|
You are right. I do not foresee anyone needing more than the Checked property, so I changed the code accordingly. |
vchelaru
added a commit
that referenced
this pull request
Apr 13, 2015
Made some parts of DeleteObjectPlugin public
vchelaru
added a commit
that referenced
this pull request
Jul 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made DeleteXmlComboBox and GetFileNameForObject public so other plugins can access this information. It is necessary for my Perforce plugin so it can remove the XML file from Perforce correctly.