Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect information for skills in hero exchange window #1324

Closed
krs0 opened this issue Dec 27, 2022 · 4 comments · Fixed by #3139
Closed

Incorrect information for skills in hero exchange window #1324

krs0 opened this issue Dec 27, 2022 · 4 comments · Fixed by #3139
Assignees
@IvanSavenko
Labels
bug

Comments

@krs0
Copy link
Collaborator

krs0 commented Dec 27, 2022

In hero exchange window, when I click any primary skill icon, I should not get any numbers, let alone negative ones!

image

When fixing, Hero Info screen should be checked as well.

  • Version: VCMI 1.1.0
@krs0 krs0 added the bug label Dec 27, 2022
@krs0
Copy link
Collaborator Author

krs0 commented May 12, 2023

negative bonuses were fixed, but now instead of actual value... only bonus appears
Below actual value is 1, but bonus of +0 appears.

image

@rilian-la-te
Copy link
Contributor

How you checked than actual value is 1?

@IvanSavenko
Copy link
Member

I can confirm this bug.
We currently don't provide skill values in exchange screen since that icon is shared between two heroes. As result, component takes placeholder value (-1 or 0) resulting in this bug.

@krs0
Copy link
Collaborator Author

krs0 commented May 12, 2023 •
edited

How you checked than actual value is 1?

by lookin very intensly at it :)

@IvanSavenko IvanSavenko self-assigned this Nov 2, 2023
@IvanSavenko IvanSavenko mentioned this issue Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IvanSavenko IvanSavenko

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactoring of Component class IvanSavenko/vcmi
3 participants
@rilian-la-te @IvanSavenko @krs0