Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Failing tests with excon 0.16.2 #193

Closed
begriffs opened this Issue · 3 comments

3 participants

@begriffs

Failed rspec run against commit 93aa595. Dowgrading the excon gem to 0.16.1 fixes it.

Rspec output:
https://gist.github.com/3505211

@Jacobkg
Collaborator

I confirm that between excon 0.16.1 and 0.16.2, we get 2 failures in the specs. Investigating...

@Jacobkg
Collaborator

This is the commit that caused the break:

excon/excon@343665c

@myronmarston

Nice sleuthing. It's not clear to me why that would cause it to fail, but this code in VCR may be related:

https://github.com/myronmarston/vcr/blob/master/lib/vcr/library_hooks/excon.rb#L49-65

@myronmarston myronmarston closed this issue from a commit
@myronmarston myronmarston Fix excon compatibility.
We need to remove the undesirable options from the connection's instance variable params, and not simply from the params that are passed to #request.

I suspect that there might have been edge case bugs before now with the old
logic.

Fixes #193.
f7beeed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.