Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing tests with excon 0.16.2 #193

Closed
begriffs opened this issue Aug 28, 2012 · 3 comments
Closed

Failing tests with excon 0.16.2 #193

begriffs opened this issue Aug 28, 2012 · 3 comments

Comments

@begriffs
Copy link

Failed rspec run against commit 93aa595. Dowgrading the excon gem to 0.16.1 fixes it.

Rspec output:
https://gist.github.com/3505211
@Jacobkg
Copy link
Contributor

Jacobkg commented Aug 30, 2012

I confirm that between excon 0.16.1 and 0.16.2, we get 2 failures in the specs. Investigating...

@Jacobkg
Copy link
Contributor

Jacobkg commented Aug 30, 2012

This is the commit that caused the break:

excon/excon@343665c

@myronmarston
Copy link
Member

Nice sleuthing. It's not clear to me why that would cause it to fail, but this code in VCR may be related:

https://github.com/myronmarston/vcr/blob/master/lib/vcr/library_hooks/excon.rb#L49-65

@myronmarston myronmarston mentioned this issue Mar 7, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@myronmarston @Jacobkg @begriffs