Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from kaptan to ConfigReader #397

Merged
merged 7 commits into from
Oct 1, 2022
Merged

Move from kaptan to ConfigReader #397

merged 7 commits into from
Oct 1, 2022

Conversation

tony
Copy link
Member

@tony tony commented Oct 1, 2022 •
edited

  • build(deps): Add types-PyYAML
  • Remove kaptan
  • Add ConfigReader: 200 lines of code, typed, w/ doctests

@codecov
Copy link

codecov bot commented Oct 1, 2022 •
edited

Codecov Report

Merging #397 (d29fa6d) into master (a88b98e) will decrease coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #397      +/-   ##
==========================================
- Coverage   84.79%   84.59%   -0.20%     
==========================================
  Files          15       15              
  Lines         855      844      -11     
  Branches      133      133              
==========================================
- Hits          725      714      -11     
  Misses         94       94              
  Partials       36       36
Impacted Files Coverage Δ
src/vcspull/config.py 86.02% <100.00%> (-0.21%) ⬇️
tests/helpers.py 76.66% <100.00%> (-2.13%) ⬇️
tests/test_config_file.py 95.32% <100.00%> (-0.11%) ⬇️
tests/test_sync.py 91.30% <100.00%> (-0.25%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tony tony force-pushed the master branch 2 times, most recently from 54b2d28 to b9c0aa1 Compare October 1, 2022 16:00
@tony tony force-pushed the rm-kaptan branch 2 times, most recently from c64fba0 to 8d2946c Compare October 1, 2022 17:32
@tony tony marked this pull request as ready for review October 1, 2022 17:46
@tony tony mentioned this pull request Oct 1, 2022
Merged
@tony tony merged commit a1defec into master Oct 1, 2022
tony added a commit that referenced this pull request Oct 1, 2022
@tony
Tag v1.14.0a0 (kaptan -> ConfigReader, #397)
a6ec699
@tony tony deleted the rm-kaptan branch October 1, 2022 17:52
tony added a commit that referenced this pull request Oct 1, 2022
@tony
Tag v1.14.0 (test improvements, move to ConfigReader in #397)
659ea41
tony added a commit that referenced this pull request Oct 8, 2022
@tony
build(deps): Add missing pyyaml dep
933d11c 
This is needed after transition of kaptan to our new ConfigReader in #397
tony added a commit that referenced this pull request Oct 8, 2022
@tony
Tag v1.15.2 (missing pyyaml dependency)
991693e 
This is needed after #397's merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tony