Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Pagination Component to Storybook #104

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

KushalNerella07
Copy link
Contributor

  • Added a Pagination component story to Storybook for better visualization and testing.
  • Maintained state in the Storybook story to demonstrate the Pagination component's functionality.

Ready for review and feedback.

- Added a Pagination component story to Storybook for better visualization and testing.
- Maintained state in the Storybook story to demonstrate the Pagination component's functionality.

Ready for review and feedback.
Copy link
Owner

@vczb vczb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase to resolve the conflict and we can safely merge it

image

@KushalNerella07
Copy link
Contributor Author

I am new to this. Apologize if the last merge was not correct but I think the build failed. I have updated the packages/index.tsx

@vczb
Copy link
Owner

vczb commented Oct 11, 2023

I am new to this. Apologize if the last merge was not correct but I think the build failed. I have updated the packages/index.tsx

No worries, I can help you

Copy link
Owner

@vczb vczb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vczb vczb merged commit 9ff104b into vczb:main Oct 11, 2023
1 check failed
@KushalNerella07 KushalNerella07 deleted the fix/pagination-component branch October 11, 2023 18:04
@KushalNerella07 KushalNerella07 restored the fix/pagination-component branch October 17, 2023 19:38
@KushalNerella07 KushalNerella07 deleted the fix/pagination-component branch October 17, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants