Add new grafana dashboard for agent memory metrics (#2279)

* add new dashboard for agent memory Signed-off-by: Kosuke Morimoto <ksk@vdaas.org> * bugfix Signed-off-by: Kosuke Morimoto <ksk@vdaas.org> --------- Signed-off-by: Kosuke Morimoto <ksk@vdaas.org> Co-authored-by: Yusuke Kato <kpango@vdaas.org>
vdaas · Dec 27, 2023 · dd2c92b · dd2c92b
1 parent 78bd472
commit dd2c92b
Show file tree

Hide file tree

Showing 3 changed files with 4,058 additions and 3 deletions.
diff --git a/internal/observability/metrics/mem/mem.go b/internal/observability/metrics/mem/mem.go
@@ -600,13 +600,15 @@ func (mm *memMetrics) Register(m metrics.Meter) error {
 	return m.RegisterCallback(
 		instruments,
 		func(ctx context.Context) {
-			var mstats runtime.MemStats
-			runtime.ReadMemStats(&mstats)
+			metrics := getMemstatsMetrics()
+			if m, err := getProcStatusMetrics(mm.pid); err == nil {
+				metrics = append(metrics, m...)
+			}
 
 			for i, instrument := range instruments {
 				g, ok := instrument.(asyncint64.Gauge)
 				if ok {
-					g.Observe(ctx, mInfo[i].Value())
+					g.Observe(ctx, metrics[i].Value())
 				}
 			}
 		},