Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ChatOpts /gen-test command error #1993

Merged
merged 4 commits into from
Apr 5, 2023

Conversation

kevindiu
Copy link
Contributor

@kevindiu kevindiu commented Mar 30, 2023

Description:

This PR fixes the ChatOpts command /gen-test CI error.

Error log:
https://github.com/vdaas/vald/actions/runs/4592104780/jobs/8108855745

Related Issue:

Versions:

  • Go Version: 1.20.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.9

Checklist:

Special notes for your reviewer:

Since the Github action always triggered base on the main branch due to security reason, the changes of this PR will not be affected until this PR is merged.
After this PR is reviewed and merged, I will create another PR to test the ChatOpts command /gen-test.

@kevindiu
Copy link
Contributor Author

/gen-test

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vdaas-ci
Copy link
Collaborator

[GEN TEST] Generating missing test files triggered by kevindiu.

@vdaas-ci
Copy link
Collaborator

[GEN TEST] Failed to generate tests.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 30, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e853075
Status: ✅  Deploy successful!
Preview URL: https://175fd95d.vald.pages.dev
Branch Preview URL: https://test-create-empty-test-with.vald.pages.dev

View logs

@kevindiu
Copy link
Contributor Author

/gen-test

@vdaas-ci
Copy link
Collaborator

[GEN TEST] Generating missing test files triggered by kevindiu.

@vdaas-ci
Copy link
Collaborator

[GEN TEST] Failed to generate tests.

@kevindiu
Copy link
Contributor Author

kevindiu commented Apr 3, 2023

/gen-test

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Apr 3, 2023

[GEN TEST] Generating missing test files triggered by kevindiu.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Apr 3, 2023

[GEN TEST] Failed to generate tests.

@kevindiu
Copy link
Contributor Author

kevindiu commented Apr 3, 2023

/gen-test

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Apr 3, 2023

[GEN TEST] Generating missing test files triggered by kevindiu.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Apr 3, 2023

[GEN TEST] Failed to generate tests.

@kevindiu
Copy link
Contributor Author

kevindiu commented Apr 3, 2023

/gen-test

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Apr 3, 2023

[GEN TEST] Generating missing test files triggered by kevindiu.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Apr 3, 2023

[GEN TEST] Failed to generate tests.

Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
@kevindiu kevindiu force-pushed the test/create-empty-test-with-placeholder branch from a21177c to e853075 Compare April 3, 2023 08:45
@kevindiu kevindiu changed the title [WIP] Create empty test with placeholder using ChatOpts Create empty test with placeholder using ChatOpts Apr 3, 2023
@kevindiu kevindiu marked this pull request as ready for review April 3, 2023 09:07
@kevindiu kevindiu requested a review from vankichi April 3, 2023 09:07
@kevindiu kevindiu requested review from a team and hlts2 and removed request for a team April 3, 2023 09:07
@kevindiu kevindiu changed the title Create empty test with placeholder using ChatOpts Fix ChatOpts /gen-test command error Apr 3, 2023
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevindiu kevindiu merged commit 5d02473 into main Apr 5, 2023
@kevindiu kevindiu deleted the test/create-empty-test-with-placeholder branch April 5, 2023 04:45
@ykadowak ykadowak mentioned this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants