Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add commit hash build image #2359

Merged
merged 2 commits into from Feb 16, 2024
Merged

add commit hash build image #2359

merged 2 commits into from Feb 16, 2024
+5 −0

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Feb 15, 2024

Description

SSIA

Related Issue

Versions

  • Go Version: 1.22.0
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.29.2
  • NGT Version: 2.1.6

Checklist

Special notes for your reviewer

@kpango
add commit hash build image
d92158e 
Signed-off-by: kpango <kpango@vdaas.org>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@kpango kpango requested review from a team, kmrmt, datelier and hlts2 and removed request for a team and kmrmt February 15, 2024 08:35
hlts2
hlts2 approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented Feb 16, 2024 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8e36996
Status: ✅  Deploy successful!
Preview URL: https://0c29a46f.vald.pages.dev
Branch Preview URL: https://ci-docker-build-add-commit-h.vald.pages.dev

View logs

@datelier datelier merged commit b906fd2 into main Feb 16, 2024
20 of 21 checks passed
@datelier datelier deleted the ci/docker-build/add-commit-hash-tag branch February 16, 2024 07:53
vdaas-ci pushed a commit that referenced this pull request Feb 16, 2024
@kpango @vdaas-ci
add commit hash build image (#2359)
52ada6d 
Signed-off-by: kpango <kpango@vdaas.org>
kpango added a commit that referenced this pull request Feb 16, 2024
@vdaas-ci @kpango
add commit hash build image (#2359) (#2371)
1326e72 
Signed-off-by: kpango <kpango@vdaas.org>
Co-authored-by: Yusuke Kato <kpango@vdaas.org>
kpango added a commit that referenced this pull request Feb 19, 2024
@kpango
fix: git add chart directory for release (#2356)
17d965f 
🔖 🤖 Release v1.7.11 (#2360) (#2361)
Change docker scan timeout longer (#2363)
refactor code using golangci-lint (#2362)
Create SECURITY.md (#2367)
add commit hash build image (#2359)
Make agent export index metrics to Pod k8s resource (#2319)
update docker build target platform selection rules (#2370)
improve Backport Pull Request Title & Description Quality (#2373)
update deps & re-generate k8s templates

Signed-off-by: kpango <kpango@vdaas.org>
@vankichi vankichi mentioned this pull request Feb 21, 2024
Merged
This was referenced Mar 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlts2 hlts2 hlts2 approved these changes

@datelier datelier datelier approved these changes

Assignees
No one assigned
Labels
actions/backport/release/v1.7 priority/low size/S type/ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kpango @vdaas-ci @hlts2 @datelier