refactor code using golangci-lint #2362
Conversation
Signed-off-by: kpango <kpango@vdaas.org>
kpango
requested review from
a team,
hlts2 and
ykadowak
and removed request for
a team
|
[CHATOPS:HELP] ChatOps commands.
|
|
[WARNING:INTCFG] Changes in |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -265,13 +265,13 @@ func TestNewDialer(t *testing.T) { | |||
| return errors.Errorf("got: \"%+v\" is not a dialer", gotDer) | |||
| } | |||
| // skipcq: VET-V0008 | |||
| //nolint: govet,copylocks | |||
| //nolint:govet,copylocks | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
directive //nolint:govet,copylocks is unused for linter "govet" (nolintlint)
| if diff := comparator.Diff(*want, *got, | ||
| // skipcq: VET-V0008 | ||
| //nolint: govet,copylocks | ||
| //nolint:govet,copylocks |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
directive //nolint:govet,copylocks is unused for linter "govet" (nolintlint)
| comparator.IgnoreFields(*want, "dialer", "der", "addrs", "dnsCachedOnce", "dnsCache", "ctrl", "tmu"), | ||
| // skipcq: VET-V0008 | ||
| //nolint: govet,copylocks | ||
| //nolint:govet,copylocks |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
directive //nolint:govet,copylocks is unused for linter "govet" (nolintlint)
| @@ -22,8 +22,10 @@ import ( | |||
| type Option func(*correct) error | |||
|
|
|||
| var defaultOpts = []Option{ | |||
| WithStreamListConcurrency(200), //nolint:gomnd | |||
| WithKvsAsyncWriteConcurrency(2048), //nolint:gomnd | |||
| //nolint:gomnd | |||
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
directive //nolint:gomnd is unused for linter "gomnd" (nolintlint)
| WithKvsAsyncWriteConcurrency(2048), //nolint:gomnd | ||
| //nolint:gomnd | ||
| WithStreamListConcurrency(200), | ||
| //nolint:gomnd |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
directive //nolint:gomnd is unused for linter "gomnd" (nolintlint)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2362 +/- ##
=======================================
Coverage 18.70% 18.70%
=======================================
Files 548 548
Lines 73641 73640 -1
=======================================
+ Hits 13776 13778 +2
+ Misses 59132 59128 -4
- Partials 733 734 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: kpango <kpango@vdaas.org>
🔖 🤖 Release v1.7.11 (#2360) (#2361) Change docker scan timeout longer (#2363) refactor code using golangci-lint (#2362) Create SECURITY.md (#2367) add commit hash build image (#2359) Make agent export index metrics to Pod k8s resource (#2319) update docker build target platform selection rules (#2370) improve Backport Pull Request Title & Description Quality (#2373) update deps & re-generate k8s templates Signed-off-by: kpango <kpango@vdaas.org>
Description
SSIA
Related Issue
Versions
Checklist
Special notes for your reviewer