Bugfix: Build error of pkg/internal/ kvs test #2396
Merged
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Deploying with
|
| Latest commit: |
b88abfc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://25dd97df.vald.pages.dev |
| Branch Preview URL: | https://bugfix-pkg-agent-internal-bu.vald.pages.dev |
vankichi
approved these changes
Feb 21, 2024
github-actions
bot
added
area/agent/core/faiss
area/agent/core/ngt
size/S
type/bug
|
[CHATOPS:HELP] ChatOps commands.
|
kpango
approved these changes
Feb 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2396 +/- ##
==========================================
+ Coverage 18.63% 18.69% +0.06%
==========================================
Files 547 549 +2
Lines 73761 73854 +93
==========================================
+ Hits 13745 13810 +65
- Misses 59279 59302 +23
- Partials 737 742 +5 ☔ View full report in Codecov by Sentry. |
vdaas-ci
pushed a commit
that referenced
this pull request
Feb 21, 2024
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
vankichi
pushed a commit
that referenced
this pull request
Feb 21, 2024
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a build error in the
pkg/internal/kvstest, so I fixed it in this PR.https://github.com/vdaas/vald/actions/runs/7983231997/job/21798053354?pr=2394
Related Issue
Versions
Checklist
Special notes for your reviewer