Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #2396 to release/v1.7 for Bugfix: Build error of pkg/internal/ kvs test #2398

Conversation

vdaas-ci
Copy link
Collaborator

Description

There was a build error in the pkg/internal/kvs test, so I fixed it in this PR.

https://github.com/vdaas/vald/actions/runs/7983231997/job/21798053354?pr=2394

Related Issue

Versions

  • Go Version: 1.22.0
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.29.2
  • NGT Version: 2.1.6

Checklist

Special notes for your reviewer

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@vdaas-ci
Copy link
Collaborator Author

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1d6d613
Status: ✅  Deploy successful!
Preview URL: https://fd4d1494.vald.pages.dev
Branch Preview URL: https://backport-release-v1-7-bugfix-2ktp.vald.pages.dev

View logs

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/v1.7@dd7be4c). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff               @@
##             release/v1.7    #2398   +/-   ##
===============================================
  Coverage                ?   18.62%           
===============================================
  Files                   ?      547           
  Lines                   ?    73767           
  Branches                ?        0           
===============================================
  Hits                    ?    13742           
  Misses                  ?    59290           
  Partials                ?      735           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hlts2 hlts2 changed the title Backport PR #2396 to release/v1.7 for Bugfix: Build error of pkg/internal/ kvs test [Merge Pending] Backport PR #2396 to release/v1.7 for Bugfix: Build error of pkg/internal/ kvs test Feb 21, 2024
@hlts2 hlts2 changed the title [Merge Pending] Backport PR #2396 to release/v1.7 for Bugfix: Build error of pkg/internal/ kvs test Backport PR #2396 to release/v1.7 for Bugfix: Build error of pkg/internal/ kvs test Feb 21, 2024
@vankichi vankichi merged commit 92032a6 into release/v1.7 Feb 21, 2024
34 of 36 checks passed
@vankichi vankichi deleted the backport/release/v1.7/bugfix/pkg/agent-internal-build-error branch February 21, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants