Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change fmt.Errorf to errors.Errorf #361

Merged
merged 2 commits into from
May 1, 2020

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented May 1, 2020

Signed-off-by: kpango i.can.feel.gravity@gmail.com

Description:

replace fmt.Errorf to errors.Errorf

Related Issue:

How Has This Been Tested?:

Environment:

  • Golang Version: 1.14
  • Docker Version: 19.03.5
  • Kubernetes Version: 1.17.3
  • NGT Version: 1.9.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
@pull-assistant
Copy link

pull-assistant bot commented May 1, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     change fmt.Errorf to errors.Errorf

     🤖 Update license headers and formatting go codes

Powered by Pull Assistant. Last update 8fa68fa ... 60a9ea5. Read the comment docs.

hlts2
hlts2 previously approved these changes May 1, 2020
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you for correcting my mistake. 🙏

@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #361 into master will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #361      +/-   ##
=========================================
- Coverage    7.99%   7.94%   -0.06%     
=========================================
  Files         345     345              
  Lines       17733   17733              
=========================================
- Hits         1417    1408       -9     
- Misses      16137   16144       +7     
- Partials      179     181       +2     
Impacted Files Coverage Δ
hack/benchmark/internal/assets/loader.go 0.00% <0.00%> (ø)
internal/net/http/middleware/timeout.go 77.41% <0.00%> (-22.59%) ⬇️
internal/safety/safety.go 90.00% <0.00%> (-10.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01847a6...60a9ea5. Read the comment docs.

vankichi
vankichi previously approved these changes May 1, 2020
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@vankichi
Copy link
Contributor

vankichi commented May 1, 2020

/approve
/rebase
/format

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented May 1, 2020

[REBASE] Rebase triggered by vankichi for branch: refactor/test/change-errorf-package

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented May 1, 2020

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

Signed-off-by: vdaas-ci <ci@vdaas.org>
@vdaas-ci vdaas-ci dismissed stale reviews from vankichi and hlts2 via 60a9ea5 May 1, 2020 07:42
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@kpango kpango merged commit 54fba1f into master May 1, 2020
@kpango kpango deleted the refactor/test/change-errorf-package branch May 1, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants