Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix /format command #466

Merged
merged 3 commits into from
Jun 10, 2020
Merged

Fix /format command #466

merged 3 commits into from
Jun 10, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Jun 10, 2020

Description:

Fix /format command

Related Issue:

nothing.

How Has This Been Tested?:

nothing.

Environment:

  • Go Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

rinx added 2 commits June 10, 2020 18:28
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@pull-assistant
Copy link

pull-assistant bot commented Jun 10, 2020

Score: 0.67

Best reviewed: commit by commit


Optimal code review plan (1 warning)

🐛 Fix /format command

.github/workflows/chatops.yml 50% changes removed in 🐛 Fix

     🐛 Fix

     Merge branch 'master' into ci/chatops/fix-format-command

Powered by Pull Assistant. Last update ca81ee7 ... 7d0f0a1. Read the comment docs.

@rinx rinx merged commit 3e810ac into master Jun 10, 2020
@rinx rinx deleted the ci/chatops/fix-format-command branch June 10, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant