Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add upsert flow in architecture doc #627

Merged
merged 6 commits into from
Aug 20, 2020
Merged

Add upsert flow in architecture doc #627

merged 6 commits into from
Aug 20, 2020

Conversation

kevindiu
Copy link
Contributor

@kevindiu kevindiu commented Aug 13, 2020 •
edited
Loading

Description:

This PR add upsert flow to the architecture document

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.14.4
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.0

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Aug 13, 2020 •
edited
Loading

Score: 0.77

Best reviewed: commit by commit

Optimal code review plan (2 warnings)

     add upsert flow

fix CI

docs/overview/architecture.md 50% changes removed in apply suggestions

apply suggestions

docs/overview/architecture.md 50% changes removed in apply suggestion

     apply suggestion

     fix

     fix

Powered by Pull Assistant. Last update 6fffbaa ... 80c00a7. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase master

@kevindiu
Copy link
Contributor Author

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by kevindiu for branch: documentation/arch_doc/add_upsert_flow

@vdaas-ci vdaas-ci force-pushed the documentation/arch_doc/add_upsert_flow branch from df77832 to 48773a8 Compare August 13, 2020 09:01
github-actions[bot]
github-actions bot reviewed Aug 13, 2020
View reviewed changes
docs/overview/architecture.md Show resolved Hide resolved
docs/overview/architecture.md Show resolved Hide resolved
docs/overview/architecture.md Outdated Show resolved Hide resolved
docs/overview/architecture.md Outdated Show resolved Hide resolved
@kevindiu kevindiu changed the title add upsert flow [WIP] Add upsert flow in architecture doc Aug 13, 2020
@kevindiu kevindiu requested a review from hlts2 August 13, 2020 09:24
@kevindiu kevindiu changed the title [WIP] Add upsert flow in architecture doc Add upsert flow in architecture doc Aug 13, 2020
hlts2
hlts2 requested changes Aug 14, 2020
View reviewed changes
docs/overview/architecture.md Outdated Show resolved Hide resolved
docs/overview/architecture.md Outdated Show resolved Hide resolved
docs/overview/architecture.md Outdated Show resolved Hide resolved
vankichi
vankichi reviewed Aug 17, 2020
View reviewed changes
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevindiu
Each image of component show not well.

docs/overview/architecture.md Outdated Show resolved Hide resolved
@kevindiu kevindiu requested a review from hlts2 August 17, 2020 08:16
@kevindiu
Copy link
Contributor Author

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by kevindiu for branch: documentation/arch_doc/add_upsert_flow

@vdaas-ci vdaas-ci force-pushed the documentation/arch_doc/add_upsert_flow branch from 640a0b8 to fd9e1da Compare August 17, 2020 09:10
hlts2
hlts2 previously approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevindiu kevindiu requested a review from vankichi August 17, 2020 09:27
vankichi
vankichi previously approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
please ask for authors whether this data flow is absolutely correct or not.

@kevindiu kevindiu requested review from kpango, rinx and kmrmt August 18, 2020 09:11
@rinx
Copy link
Contributor

rinx commented Aug 19, 2020

seems good to me.

kpango
kpango previously approved these changes Aug 20, 2020
View reviewed changes
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango
Copy link
Collaborator

kpango commented Aug 20, 2020

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by kpango for branch: documentation/arch_doc/add_upsert_flow

@vdaas-ci vdaas-ci dismissed stale reviews from kpango, vankichi, and hlts2 via 80c00a7 August 20, 2020 05:08
@vdaas-ci vdaas-ci force-pushed the documentation/arch_doc/add_upsert_flow branch from fd9e1da to 80c00a7 Compare August 20, 2020 05:08
@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by kpango.

vdaas-ci
vdaas-ci approved these changes Aug 20, 2020
View reviewed changes
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by kpango.

@kpango kpango merged commit b52b466 into master Aug 20, 2020
@kpango kpango deleted the documentation/arch_doc/add_upsert_flow branch August 20, 2020 05:36
@vdaas-ci vdaas-ci mentioned this pull request Sep 2, 2020
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@vdaas-ci vdaas-ci vdaas-ci approved these changes

@kpango kpango kpango left review comments

@vankichi vankichi vankichi left review comments

@hlts2 hlts2 hlts2 left review comments

@rinx rinx Awaiting requested review from rinx

@kmrmt kmrmt Awaiting requested review from kmrmt

Assignees
No one assigned
Labels
priority/low size/S status/author-review type/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kevindiu @vdaas-ci @rinx @kpango @vankichi @hlts2