Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] update deps #660

Merged
merged 7 commits into from
Sep 2, 2020
Merged

[patch] update deps #660

merged 7 commits into from
Sep 2, 2020

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Sep 1, 2020

Description:

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.14.4
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.0

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Sep 1, 2020

Score: 0.59

Best reviewed: commit by commit


Optimal code review plan (3 warnings)

[patch] update dependencies

go.mod 74% changes removed in fix

go.sum 83% changes removed in fix

hack/go.mod.default 89% changes removed in fix

fix

hack/go.mod.default 50% changes removed in fix

fix

go.mod 50% changes removed in fix

go.sum 50% changes removed in fix

     fix

     fix

     fix

     fix

Powered by Pull Assistant. Last update 0d83932 ... dc253d5. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Sep 1, 2020

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
hack/go.mod.default Outdated Show resolved Hide resolved
@kevindiu
Copy link
Contributor

kevindiu commented Sep 2, 2020

do we also do the patch release in this PR?

@kpango
Copy link
Collaborator Author

kpango commented Sep 2, 2020

/rebase
/format
/approve

@kpango kpango changed the title update deps [patch] update deps Sep 2, 2020
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Sep 2, 2020

[REBASE] Rebase triggered by kpango for branch: dependencies/update/deps

kpango added 7 commits September 2, 2020 09:49
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Sep 2, 2020

[FORMAT] Updating license headers and formatting go codes triggered by kpango.

@kpango
Copy link
Collaborator Author

kpango commented Sep 2, 2020

/changelog

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Sep 2, 2020

[CHANGELOG] Please edit the following lines.

  • [patch] update deps (#660)
  • add metrics for indexer and sidecar (#642)
  • ✏️ fix indents in helm chart of vald-helm-operator (#658)
  • ✅ Add test for internal/compress/gob.go (#646)
  • Upgrade go mod default: k8s.io/xxx v0.18.8 (#645)
  • [Coding guideline] Add implementation and grouping section (#641)
  • ✅ add internal/compress/lz4 test (#643)
  • Add test case for s3/option.go (#640)
  • Refactoring and Add test code for compress (#622)
  • [ImgBot] Optimize images (#639)
  • Add operation guide (#541)
  • ✅ add internal/s3/reader/option test (#630)
  • 🐛 Fix indexer's creation_pool_size field (#637)
  • 🔧 revise languagetool rules: disable EN_QUOTES (#635)
  • 🔧 revise languagetool rules: disable TYPOS, DASH_RULE (#634)
  • 🔧 revise languagetool rules (#633)
  • [ImgBot] Optimize images (#632)
  • Add upsert flow in architecture doc (#627)
  • Add DB metrics & traces: Redis, MySQL (#623)
  • ✅ add internal/db/rdb/mysql/model test (#628)
  • 🔧 upload sarif only for HIGH or CRITICAL (#629)
  • ✅ add internal/db/rdb/mysql/option test (#626)
  • Add internal/net test (#615)
  • ✅ Add test for gzip_option (#625)
  • 📝 change showing image method (#624)
  • ✅ Add internal/compress/zstd_option test (#621)
  • use distroless for base image (#605)
  • 📝 Coding guideline: Add error checking section (#614)
  • ✅ add internal/compress/lz4_option test (#619)
  • ✅ fix test fail (#616)
  • ✅ Add test of internal/worker/queue_option (#613)
  • [ImgBot] Optimize images (#617)
  • 📝 Add update dataflow in architecture document (#601)
  • Add internal/worker/worker test (#602)
  • ♻️ refactor load test (#552)
  • ✅ Add test case for internal/kvs/redis/option.go (#611)
  • ✅ create internal/worker/queue test (#606)
  • ✅ ♻️ Add internal roundtrip test code (#589)
  • 📝 Documentation/performance/loadtest (#610)
  • 🤖 Automatically update k8s manifests (#609)

Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by kpango.

@kpango kpango merged commit 91edda9 into master Sep 2, 2020
@kpango kpango deleted the dependencies/update/deps branch September 2, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants